zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-02 18:11:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Elements] Update hideSearchHighlights codepath

Browse Source 
this._treeElementForNode(searchResult.node) is the combined of the two lines that get removed in this CL.

Even though they are basically the same, this CL change it to use the one-line solution for two reasons:
1. To match how the currentSearchHighlights is done (also calls the one-line solution here https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/elements/ElementsPanel.js;drc=d1a00aacb9ad57775cee6cff5e0dac11b7e1ca59;l=650?originalUrl=https:%2F%2Fcs.chromium.org%2F), so the highlight/un-highlight codepath could be more consistent
2. So we dont need extra steps here to guard against the unhandled exception when treeOutline is null in the two-line solution



Bug: 1121459
Change-Id: I680a2e0fbcf141fbea85c7030752b6ce0dd4a30c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2374285
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Michael Liao <michael.liao@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
This commit is contained in:
Christy Chen
2020-08-27 03:45:15 +00:00
committed by Commit Bot
parent 167cbab7ee
commit 447a462be3
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
front_end/elements/ElementsPanel.js
+1 -2
View File
@@ -670,8 +670,7 @@ export class ElementsPanel extends UI.Panel.Panel {
if (!searchResult.node) {
return;
}
const treeOutline = ElementsTreeOutline.forDOMModel(searchResult.node.domModel());
const treeElement = treeOutline.findTreeElement(searchResult.node);
const treeElement = this._treeElementForNode(searchResult.node);
if (treeElement) {
treeElement.hideSearchHighlights();
}