Christy Chen
447a462be3
this._treeElementForNode(searchResult.node) is the combined of the two lines that get removed in this CL. Even though they are basically the same, this CL change it to use the one-line solution for two reasons: 1. To match how the currentSearchHighlights is done (also calls the one-line solution here https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/elements/ElementsPanel.js;drc=d1a00aacb9ad57775cee6cff5e0dac11b7e1ca59;l=650?originalUrl=https:%2F%2Fcs.chromium.org%2F), so the highlight/un-highlight codepath could be more consistent 2. So we dont need extra steps here to guard against the unhandled exception when treeOutline is null in the two-line solution Bug: 1121459 Change-Id: I680a2e0fbcf141fbea85c7030752b6ce0dd4a30c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2374285 Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by: Michael Liao <michael.liao@microsoft.com> Commit-Queue: Christy Chen <chrche@microsoft.com>
Chrome DevTools frontend
The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.
Source code
The frontend is available on chromium.googlesource.com.
Design guidelines
Please be aware that DevTools follows additional development guidelines.
Issue triage
The issue triage guidelines can be found here.
Workflows
Instructions to set up, use, and maintain a DevTools frontend checkout can be found here.
Additional references
- DevTools documentation: devtools.chrome.com
- Debugging protocol docs and Chrome Debugging Protocol Viewer
- awesome-chrome-devtools: recommended tools and resources
- Contributing to DevTools: bit.ly/devtools-contribution-guide
- Contributing To Chrome DevTools Protocol: docs.google.com
- DevTools Design Review Guidelines: design_guidelines.md
Source mirrors
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
Getting in touch
-
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
-
All open DevTools tickets on crbug.com
-
File a new DevTools ticket: new.crbug.com
-
Code reviews mailing list: devtools-reviews@chromium.org
-
@ChromeDevTools on Twitter
-
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools