zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 20:11:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

[test_runner] Use dynamic import directly instead of using eval

Browse Source 
Bug: 1011811
Change-Id: Ia1391e881ba36d6c8a2cb391946d3058e87e816b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259092
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
This commit is contained in:
Simon Zünd
2021-11-04 06:25:48 +00:00
committed by Devtools-frontend LUCI CQ
parent 43e68da49f
commit 709b09e63c
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
front_end/legacy_test_runner/test_runner/test_runner.js
+2 -4
View File
@@ -59,15 +59,13 @@ export async function _executeTestScript() {
// Auto-start unit tests
self.test = async function() {
// TODO(crbug.com/1011811): Remove eval when we use TypeScript which does support dynamic imports
await eval(`import("${testScriptURL}")`);
await import(testScriptURL);
};
return;
}
try {
// TODO(crbug.com/1011811): Remove eval when we use TypeScript which does support dynamic imports
await eval(`import("${testScriptURL}")`);
await import(testScriptURL);
} catch (err) {
TestRunner.addResult('TEST ENDED EARLY DUE TO UNCAUGHT ERROR:');
TestRunner.addResult(err && err.stack || err);