zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-02 18:11:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixes UIString closure annotation

Browse Source 
No-Tree-Checks: true
TBR=jacktfranklin@chromium.org
Change-Id: I141038fc8cffaaf7ab4252c928a790443a8b0a5a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050228
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
This commit is contained in:
Paul Lewis
2020-02-11 11:44:51 +00:00
committed by Commit Bot
parent c05ee8a3ff
commit 74cb8b70d8
3 changed files with 23 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
front_end/common/UIString.js
+1 -1
View File
@@ -50,7 +50,7 @@ export function serializeUIString(string, values = []) {
}
/**
* @param {string} serializedMessage
* @param {string=} serializedMessage
* @return {*}
*/
export function deserializeUIString(serializedMessage) {
test/shared/runner.ts
+6 -1
View File
@@ -109,7 +109,12 @@ interface DevToolsTarget {
const listing = await devtools.$('pre');
const json = await devtools.evaluate(listing => listing.textContent, listing);
const targets: DevToolsTarget[] = JSON.parse(json);
const {id} = targets.find((target) => target.url === blankPage)!;
const target = targets.find((target) => target.url === blankPage);
if (!target) {
throw new Error(`Unable to find target page: ${blankPage}`);
}
const {id} = target;
await devtools.close();
// Connect to the DevTools frontend.
test/unittests/front_end/common/Color.ts
+16 -16
View File
@@ -99,31 +99,31 @@ describe('Color', () => {
});
it('parses rgb(a) values', () => {
const colorOne = Common.Color.Color.parse('rgb(255, 255, 0)');
assert.deepEqual(colorOne!.rgba(), [1, 1, 0, 1]);
const colorOne = Common.Color.Color.parse('rgb(255, 255, 0)')!;
assert.deepEqual(colorOne.rgba(), [1, 1, 0, 1]);
const colorTwo = Common.Color.Color.parse('rgba(0, 255, 255, 0.5)');
assert.deepEqual(colorTwo!.rgba(), [0, 1, 1, 0.5]);
const colorTwo = Common.Color.Color.parse('rgba(0, 255, 255, 0.5)')!;
assert.deepEqual(colorTwo.rgba(), [0, 1, 1, 0.5]);
const colorThree = Common.Color.Color.parse('rgb(255 255 255)');
assert.deepEqual(colorThree!.rgba(), [1, 1, 1, 1]);
const colorThree = Common.Color.Color.parse('rgb(255 255 255)')!;
assert.deepEqual(colorThree.rgba(), [1, 1, 1, 1]);
const colorFour = Common.Color.Color.parse('rgb(10% 10% 10%)');
assert.deepEqual(colorFour!.rgba(), [0.1, 0.1, 0.1, 1]);
const colorFour = Common.Color.Color.parse('rgb(10% 10% 10%)')!;
assert.deepEqual(colorFour.rgba(), [0.1, 0.1, 0.1, 1]);
const colorFive = Common.Color.Color.parse('rgb(10% 10% 10% / 0.4)');
assert.deepEqual(colorFive!.rgba(), [0.1, 0.1, 0.1, 0.4]);
const colorFive = Common.Color.Color.parse('rgb(10% 10% 10% / 0.4)')!;
assert.deepEqual(colorFive.rgba(), [0.1, 0.1, 0.1, 0.4]);
});
it('parses hsl(a) values', () => {
const colorOne = Common.Color.Color.parse('hsl(0, 100%, 50%)');
assert.deepEqual(colorOne!.rgba(), [1, 0, 0, 1]);
const colorOne = Common.Color.Color.parse('hsl(0, 100%, 50%)')!;
assert.deepEqual(colorOne.rgba(), [1, 0, 0, 1]);
const colorTwo = Common.Color.Color.parse('hsla(0, 100%, 50%, 0.5)');
assert.deepEqual(colorTwo!.rgba(), [1, 0, 0, 0.5]);
const colorTwo = Common.Color.Color.parse('hsla(0, 100%, 50%, 0.5)')!;
assert.deepEqual(colorTwo.rgba(), [1, 0, 0, 0.5]);
const colorThree = Common.Color.Color.parse('hsla(50deg 100% 100% / 50%)');
assert.deepEqual(colorThree!.rgba(), [1, 1, 1, 0.5]);
const colorThree = Common.Color.Color.parse('hsla(50deg 100% 100% / 50%)')!;
assert.deepEqual(colorThree.rgba(), [1, 1, 1, 0.5]);
});
it('handles invalid values', () => {