Migrate front_end/help to devtools_entrypoint

R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: I13cc2e6c8b71550d421b3f0e73559d9958db629a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2323624
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>

all_devtools_modules.gni

@@ -53,9 +53,6 @@ all_devtools_module_sources = [
   "heap_snapshot_worker/HeapSnapshotLoader.js",
   "heap_snapshot_worker/HeapSnapshotWorker.js",
   "heap_snapshot_worker/HeapSnapshotWorkerDispatcher.js",
-  "help/HelpImpl.js",
-  "help/ReleaseNoteText.js",
-  "help/ReleaseNoteView.js",
   "input/InputModel.js",
   "input/InputTimeline.js",
   "inspector_main/InspectorMain.js",
@@ -406,6 +403,9 @@ all_typescript_module_sources = [
   "har_importer/HARFormat.js",
   "har_importer/HARImporter.js",
   "heap_snapshot_model/HeapSnapshotModel.js",
+  "help/HelpImpl.js",
+  "help/ReleaseNoteText.js",
+  "help/ReleaseNoteView.js",
   "host/InspectorFrontendHost.js",
   "host/InspectorFrontendHostAPI.js",
   "host/Platform.js",

devtools_module_entrypoints.gni

@@ -43,7 +43,6 @@ devtools_module_entrypoint_sources = [
   "heap_snapshot_worker/heap_snapshot_worker-legacy.js",
   "heap_snapshot_worker/heap_snapshot_worker.js",
   "help/help-legacy.js",
-  "help/help.js",
   "host/host-legacy.js",
   "inline_editor/inline_editor-legacy.js",
   "input/input-legacy.js",
@@ -145,6 +144,7 @@ generated_typescript_entrypoint_sources = [
   "$resources_out_dir/formatter_worker/formatter_worker.js",
   "$resources_out_dir/har_importer/har_importer.js",
   "$resources_out_dir/heap_snapshot_model/heap_snapshot_model.js",
+  "$resources_out_dir/help/help.js",
   "$resources_out_dir/host/host.js",
   "$resources_out_dir/inline_editor/inline_editor.js",
   "$resources_out_dir/issues/issues.js",

front_end/BUILD.gn

@@ -29,6 +29,7 @@ group("front_end") {
     "formatter_worker:bundle",
     "har_importer:bundle",
     "heap_snapshot_model:bundle",
+    "help:bundle",
     "i18n:bundle_i18n",
     "inline_editor:bundle",
     "issues:bundle",

front_end/help/BUILD.gn

@@ -0,0 +1,27 @@
+# Copyright 2020 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("../../scripts/build/ninja/devtools_entrypoint.gni")
+import("../../scripts/build/ninja/devtools_module.gni")
+
+devtools_module("help") {
+  sources = [
+    "HelpImpl.js",
+    "ReleaseNoteText.js",
+    "ReleaseNoteView.js",
+  ]
+
+  deps = [
+    "../common:bundle",
+    "../host:bundle",
+    "../ui:bundle",
+  ]
+}
+
+devtools_entrypoint("bundle") {
+  entrypoint = "help.js"
+  is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ]
+
+  deps = [ ":help" ]
+}

front_end/help/HelpImpl.js

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// @ts-nocheck
+// TODO(crbug.com/1011811): Enable TypeScript compiler checks
+
 import * as Common from '../common/common.js';  // eslint-disable-line no-unused-vars
 import * as Host from '../host/host.js';
 import * as UI from '../ui/ui.js';  // eslint-disable-line no-unused-vars

front_end/help/ReleaseNoteText.js

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// @ts-nocheck
+// TODO(crbug.com/1011811): Enable TypeScript compiler checks
+
 // NOTE: need to be careful about adding release notes early otherwise it'll
 // be shown in Canary (e.g. make sure the release notes are accurate).
 // https://github.com/ChromeDevTools/devtools-frontend/wiki/Release-Notes

front_end/help/ReleaseNoteView.js

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// @ts-nocheck
+// TODO(crbug.com/1011811): Enable TypeScript compiler checks
+
 import * as Host from '../host/host.js';
 import * as UI from '../ui/ui.js';
 

front_end/help/module.json

@@ -72,5 +72,6 @@
   ],
   "resources": [
     "releaseNote.css"
-  ]
-}
+  ],
+  "skip_rollup": true
+}