Re-enable network request blocking panel e2e tests, and temporary replace beforeEach with an explicit function call to aid debugging. I cannot reproduce the flakiness using the trybot, let's see if it still fails.

Bug: 1259120
Change-Id: Ie20e1702408e5000e50af2746eb34c058749ca8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3804761
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
This commit is contained in:
Danil Somsikov
2022-08-02 15:58:28 +00:00
committed by Devtools-frontend LUCI CQ
parent b6b89b8c71
commit d0dee8efbd
@@ -40,9 +40,8 @@ async function disableNetworkRequestBlocking() {
expect(await checkboxIsChecked(networkRequestBlockingCheckbox)).to.equal(false);
}
// Flakey in the beforeEach step on Mac bot.
describe.skip('[crbug.com/1259120] Network request blocking panel', async () => {
beforeEach(async () => {
describe('Network request blocking panel', async () => {
async function setup() {
await navigateToNetworkRequestBlockingTab();
for (let i = 0; i < 20; i++) {
const plusButton = await waitForAria('Add pattern');
@@ -52,9 +51,10 @@ describe.skip('[crbug.com/1259120] Network request blocking panel', async () =>
const addButton = await waitForAria('Add');
await addButton.click();
}
});
}
it('pattern list inactive when blocking disabled', async () => {
await setup();
await disableNetworkRequestBlocking();
await waitForAriaNone('Edit');
@@ -68,6 +68,7 @@ describe.skip('[crbug.com/1259120] Network request blocking panel', async () =>
});
it('pattern scrollable when blocking disabled', async () => {
await setup();
await disableNetworkRequestBlocking();
const list = await waitFor('.list');