zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-13 01:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

[e2e] Fix: Remove aync describe in can-create-panels_tests.ts

Browse Source 
Passing an aync callback to describe can cause unintended behavior in mocha helpers.

Remove the `async` keyword to the describe callback. It is not needed.

If in the future async work is needed before a test is run passing an async callback to `before` is the recommended approach.
See https://mochajs.org/#using-async-await

Bug: None
Change-Id: I6ad2cef69ece58a91d333932d35e8ed5c6c1436b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4136865
Auto-Submit: John Emau <John.Emau@microsoft.com>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
This commit is contained in:
John Emau
2023-01-11 10:14:16 +00:00
committed by Devtools-frontend LUCI CQ
parent 173e00ec46
commit d48805e43a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/e2e/extensions/can-create-panels_test.ts
+1 -1
View File
@@ -15,7 +15,7 @@ import {
import {describe, it} from '../../shared/mocha-extensions.js';
import {loadExtension} from '../helpers/extension-helpers.js';
describe('The Extension API', async () => {
describe('The Extension API', () => {
it('can create panels with callbacks', async () => {
const extension = await loadExtension('TestExtension');