zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use explicit SDKModel<void> for models without events

Browse Source 
Using 'void' causes TypeScript compilation errors when someone tries
to add listeners or dispatch events on a SDKModel<void>.

R=bmeurer@chromium.org

Bug: 1228674
Change-Id: I4de24710d92d7fa4d916ec1b0a723ba6e3351ab6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3175285
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
This commit is contained in:
Simon Zünd
2021-09-22 08:52:37 +00:00
committed by Devtools-frontend LUCI CQ
parent 60260b5e6e
commit dbb8de4898
6 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
front_end/core/sdk/TracingManager.ts
+1 -1
View File
@@ -10,7 +10,7 @@ import {Capability} from './Target.js';
import {SDKModel} from './SDKModel.js';
import type {ObjectSnapshot} from './TracingModel.js';
export class TracingManager extends SDKModel {
export class TracingManager extends SDKModel<void> {
private readonly tracingAgent: ProtocolProxyApi.TracingApi;
private activeClient: TracingManagerClient|null;
private eventBufferSize: number|null;
front_end/entrypoints/node_main/NodeMain.ts
+1 -1
View File
@@ -47,7 +47,7 @@ export class NodeMainImpl implements Common.Runnable.Runnable {
Common.Runnable.registerEarlyInitializationRunnable(NodeMainImpl.instance);
export class NodeChildTargetManager extends SDK.SDKModel.SDKModel implements ProtocolProxyApi.TargetDispatcher {
export class NodeChildTargetManager extends SDK.SDKModel.SDKModel<void> implements ProtocolProxyApi.TargetDispatcher {
private readonly targetManager: SDK.TargetManager.TargetManager;
private readonly parentTarget: SDK.Target.Target;
private readonly targetAgent: ProtocolProxyApi.TargetApi;
front_end/panels/css_overview/CSSOverviewModel.ts
+1 -1
View File
@@ -41,7 +41,7 @@ export interface GlobalStyleStats {
};
}
export class CSSOverviewModel extends SDK.SDKModel.SDKModel {
export class CSSOverviewModel extends SDK.SDKModel.SDKModel<void> {
private readonly runtimeAgent: ProtocolProxyApi.RuntimeApi;
private readonly cssAgent: ProtocolProxyApi.CSSApi;
private readonly domAgent: ProtocolProxyApi.DOMApi;
front_end/panels/input/InputModel.ts
+1 -1
View File
@@ -6,7 +6,7 @@ import * as SDK from '../../core/sdk/sdk.js';
import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
import * as Protocol from '../../generated/protocol.js';
export class InputModel extends SDK.SDKModel.SDKModel {
export class InputModel extends SDK.SDKModel.SDKModel<void> {
private readonly inputAgent: ProtocolProxyApi.InputApi;
private eventDispatchTimer: number;
private dispatchEventDataList: EventData[];
front_end/panels/screencast/InputModel.ts
+1 -1
View File
@@ -6,7 +6,7 @@ import * as SDK from '../../core/sdk/sdk.js';
import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
import * as Protocol from '../../generated/protocol.js';
export class InputModel extends SDK.SDKModel.SDKModel {
export class InputModel extends SDK.SDKModel.SDKModel<void> {
private readonly inputAgent: ProtocolProxyApi.InputApi;
private activeTouchOffsetTop: number|null;
private activeTouchParams: Protocol.Input.EmulateTouchFromMouseEventRequest|null;
front_end/ui/legacy/components/utils/TargetDetachedDialog.ts
+1 -1
View File
@@ -16,7 +16,7 @@ const UIStrings = {
};
const str_ = i18n.i18n.registerUIStrings('ui/legacy/components/utils/TargetDetachedDialog.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
export class TargetDetachedDialog extends SDK.SDKModel.SDKModel implements ProtocolProxyApi.InspectorDispatcher {
export class TargetDetachedDialog extends SDK.SDKModel.SDKModel<void> implements ProtocolProxyApi.InspectorDispatcher {
private static hideCrashedDialog: (() => void)|null;
constructor(target: SDK.Target.Target) {
super(target);