Element State Pane: https://imgur.com/u6O3im1
Issue:
- Forced element state checkboxes use a table element for layout purposes
- SR is announcing the checkbox container as a table which can cause confusion to SR users
Changes:
- Set the role for the table element as "presentation"
Usage of "role=presentation":
The presentation role is used to remove semantic meaning from an element and any of its related child elements. For example, a table used for layout purposes could have the presentation role applied to the table element to remove any semantic meaning from the table element and any of its table related children elements, such as table headers and table data elements. Non-table related elements should retain their semantic meaning, however.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_presentation_role
Bug: 1065913
Change-Id: I24d7b2b8fccc7983a574ddd8d385e8f15e79b90d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127671
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Songtao Xia <soxia@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Instead of just highlighting the affected request in the network panel,
clicking the link now opens the detailed view for a request in the
network panel.
This CL adds a new utility method on the {NetworkPanel} that ties
together existing functionality. Currently, clicking an affected
request opens the "Headers" tab of the request. This is done because
the "Affected Requests" views is re-used for all issues where requests
are attached, not just cookie issues. In the future, we might be able
to pass along some data, so we could choose the opened tab depending
whether its a cookie or a COEP issue.
R=sigurds@chromium.org
Change-Id: I1118b2e2c428c6135f895816d1f7fdaf4d4ce79b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123481
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Some actions are being loaded by the DevTools even though they depend on
code that's hidden behind an experiment. This can cause unhandled
exceptions if a user tries to execute one of them, and will pollute the
future custom keyboard shortcut list with unusable actions. To avoid
that, this CL adds experiment attributes to those actions.
Bug: 174309
Change-Id: I3da5661af95798fdaaafc08fcc6f4d393690a93f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2099437
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Jose Leal <joselea@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
'Restore defaults and reload Dev-Tools' button of 'Dev-Tools' window
is seen chopped on increasing 'Minimum font size' to the 'maximum'.
The DevTools window can be resized to make it visible, but in the default
state, its truncated. This change restores the button text to
what it was previously.
Bug: 1064169
Change-Id: I051716bb64d1c9250196ae003697f98c184ea0b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2117364
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
This CL adjusts entrypoints for Settings.
1) Adds a Settings Gear icon to the top-level toolbar
2) Moves Settings ... menu entry to More tools submenu
https://i.imgur.com/9WS6EGy.png
This CL also includes telemetry for Settings,
so we can better evaluate how users are finding Settings,
and which Settings tabs are most popular.
1) Record a User Action for opening Settings
- Reveal Settings via Gear icon
- Reveal Settings via Top Menu -> More tools -> Settings
OR via Top Menu -> Shortcuts
- Reveal Settings via Command menu
Remark: The keyboard shortcut F1 / Shift+? to reveal Settings
does not record an action here; keyboard shortcut telemetry for the
settings.show action is already taken care of.
2) Report Panel Open action for each Settings tab
- On reveal: should report exactly the panel opened once
- On switch tabs: should report exactly the panel switched to once
The corresponding Chrome CL to add the new enums is here.
https://chromium-review.googlesource.com/c/chromium/src/+/2055359
In order to have the Settings screen record Panel Open actions
reliably, a new TabInvoked event was added to TabbedPane which is
triggered by all tab selections, both programmatic and user invoked.
The existing TabSelected event only triggers on tab changes.
Using TabSelected prevent the Settings screen from reporting panel open
events when closed and re-opened to the same tab.
One criteria for determining whether to report a panel open is that
the tab is invoked by a user (userGesture) and not programmatically.
For user invokable items in context menu and the Command menu,
this userGesture argument is now set to `true` by default,
as both must have been invoked by a user.
Bug: 1050855
Change-Id: Id2e6e5f995bf2e6d419a3144eeec3e6af2bf208b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2049183
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Jack Lynch <jalyn@microsoft.com>
Commit-Queue: Brian Cui <brcui@microsoft.com>
The test will check the generated .tsbuildinfo against the expected.tsbuildinfo
and ensures that the content is equal.
I initially tried to generate twice and compare the outputs, but for some reason
the two runs would always be identical (even though sometimes the content of
both files could differ between other runs). Therefore, I opted for checking
for the full output instead. Thus we will need to update the expectation file
whenever we are updating the typescript version we are using.
R=jacktfranklin@chromium.org
Bug: 1064287, 1058578, 1054494
Change-Id: I198e1907f674d930696744c18f11bf2321a8fd37
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2122138
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Currently, workers don't support the audits domain. A WIP CL for adding
the audits domain is here: https://crrev.com/c/2119539
Until we support the audits domain, we must only enable the audits
domain for targets that support it, i.e. frames.
This CL adds a new capability Audits that only frames have, and
associates the IssuesModel with that capability, effectively ensuring
that only frames get an associated IssuesModel.
Bug: chromium:1064587
Change-Id: Ib6bc3374874d48a50f55ceb74a5af8e5ecd0a91a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119543
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
DevTool themes are applied by patching css properties that modify
colors and copying the ruleset to a separate stylesheet. This
stylesheet is added to the appropriate shadow DOM when its component
is loaded.
High contrast themes use system colors instead of the Devtools patching
mechanism to set color values. However, there are cases where the patched
stylesheet rulesets are higher specificity than rulesets defined in
forced-colors media blocks.
This patch short circuits the patching and application of theme-specific
stylesheets when forced-colors is active.
Before: https://imgur.com/tLnAxTN
After: https://imgur.com/4a3kdPM
Bug: 1048378
Change-Id: I7fc26757d06dd77688ce3cfd823389767d999e3f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2116947
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
This CL fixes an issue that causes the network Log area to receive
a focus indicator when the "Learn More" link is focused/clicked.
This issue was caused because the logic to trigger the focus ring
on the network log area assumed the only focusable content within the
container was the DataGrid. It previously showed the ring whenever
focus was within the container and the datagrid did not have a request
selected.
Now it only shows if the datagrid receives focus and does not have
a node selected.
(Note that this focus logic was included because the
waterfall column is not part of the Datagrid)
Before: https://imgur.com/2cGS207
After: https://imgur.com/LzEDWBW
Bug: 1056138
Change-Id: I5c1f5fd03b5ed674f27c5b591fc76cfa4d46d165
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2120649
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Paul Lewis
