zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-12 17:45:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
11,075 Commits 45 Branches 79 Tags
700db8d40ca419ab4cebb9bf63aa8d3fcf52cecc
Commit Graph
11075 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Simon Zünd 700db8d40c [sync] Enable syncing of standard and custom emulated devices 
R=wolfi@chromium.org

Bug: 1245541
Change-Id: I9a96a20cf43df82c623089f1d7911d5373f645a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240365
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-25 09:10:21 +00:00
Johan Bay ede4c59ac3 Update list of devices for previewing 
This change introduces devices with more modern specifications in
device preview/emulation.

Doc: https://docs.google.com/document/d/10nnjf1VAVujfEueAfCYyQgV85ePy_ZwZb56TICAytcE/edit?usp=sharing
Bug: 1223525
Change-Id: Ic049e245ef8a6bf6a11e17ee9d602472b606974a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3043955
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-10-25 07:28:30 +00:00
Mathias Bynens 50a215231f Prefer Set#has over Array#includes 
Bug: none
Change-Id: Id260be33e2270d8a932d4bf920a9daa86d42b003
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3238871
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
 2021-10-25 07:04:40 +00:00
devtools-ci-autoroll-builder b56190004c Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ia08c99ec0c4b48f3095c5e66fa9aa64708836173
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3239897
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-25 06:40:39 +00:00
devtools-ci-autoroll-builder 051ddce0b5 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/7bc6934..acad0f2

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I1806a84d7fbdf777ef393c47350abc43592e8250
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3239890
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-25 04:04:49 +00:00
devtools-ci-autoroll-builder ee765f2d4d Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/ad1e3fb..7bc6934

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ibdc6c4c4a76481cdd9c30a7448c696315d825929
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3239669
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-24 12:40:03 +00:00
devtools-ci-autoroll-builder 997a0253e3 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ic5123775ea7e799454cf9fe49ad2fa83c82e3433
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3239107
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-24 06:59:44 +00:00
devtools-ci-autoroll-builder 0c0961a40f Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/cc1fc90..ad1e3fb

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I0432eeb49bffa1aee1343aa85eaddeabdddcdde9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3239565
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-24 03:48:23 +00:00
devtools-ci-autoroll-builder 523cabf3aa Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/263ec78..cc1fc90

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I0a7baaa37e300b0f9786d06671529c2018263468
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3239220
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-23 12:42:02 +00:00
devtools-ci-autoroll-builder c0692cb385 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I41092de5eb9a9b1bf47b367c46e96ee27b2eb7d4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3239151
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-23 06:41:32 +00:00
devtools-ci-autoroll-builder 75057afb81 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/ffe1c75..263ec78

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Iddcc967cd8aa5dc373d29d7a261788b004aa54a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3239145
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-23 03:49:22 +00:00
devtools-ci-autoroll-builder 9f9867d3f2 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/4d4596d..ffe1c75

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ie960a7c516c3220d77822b6e16f17c51467d03a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3238229
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-22 12:42:52 +00:00
devtools-ci-autoroll-builder 59355a8f7a Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I2f99a96c79536c58e498f68b4cbda4b5097973fa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3238228
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-22 06:39:32 +00:00
devtools-ci-autoroll-builder d04c0e80d0 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/ee9068d..4d4596d

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a64ac73..7a6ff98

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I92bbc19c0157f40dba745c9a132180f40d24d6e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3238225
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-22 03:53:33 +00:00
Paul Irish 6ee740ea29 [Lighthouse] Remove DOM check when adding view trace button 
Lighthouse's `addButton` handles this for us–and besides,
the DOM has changed and this check is no longer valid.

Bug: 1262253
Change-Id: I63a1442a07fb139a6a7d760f76d57e546b36e0f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3237595
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
 2021-10-21 20:32:19 +00:00
Andrey Kosyakov 1139798e6b Correctly show contentDocument of OOPIFs created by <embed> and <object> 
This implement handling for frame owner elements like <embed> and <object>
consistent with the way we handle iframes.

- treat "webview" targets similarly to iframes;
- request child document for <embed> and <object> elements in addition to <iframe>
- (drive-by) createChildDocumentPromiseForTesting => requestChildDocument, because
it's not specific to testing.

Bug: 1250673
Change-Id: I183ae0e55fee0368721cf401c8a7d5148bed071c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3235721
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-10-21 18:39:15 +00:00
devtools-ci-autoroll-builder 3c3302dc25 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/3315329..ee9068d

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5cffc19..a64ac73

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ib10f8b450837acccf015ef072167349a483acca7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3233768
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-21 12:56:33 +00:00
devtools-ci-autoroll-builder 55b768e0ac Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I9e34398dcdaa994b49846549acfe3dc0dd9ee019
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3235940
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-21 06:47:22 +00:00
Yang Guo cb324bb408 Consistent warning background for console context dropdown 
Fixed:1238240
Change-Id: Ia055745757f5aec030e06df08bda7dd3ad4df238
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234190
Reviewed-by: Mraz Marian <mraz@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-10-21 06:11:44 +00:00
devtools-ci-autoroll-builder 3eb01379c0 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/3ab5542..3315329

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/aa2fb01..f5750f5

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b6ce244..5cffc19

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: If0053830463c9fea3fa6f3fb56d368b16afc2211
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3235811
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-21 03:46:05 +00:00
Simon Zünd e03b7a0f6f [sync] Add custom rendering for the 'Sync' section in the settings UI 
This CL adds a new web component 'SyncSection' that shows the avatar
plus email of the currently logged in user, or a warning if the
user does not have sync enabled.

Screenshots: https://imgur.com/a/PI5I1mh

Drive-by: 'arePreferencesSynced' is only optionally provided by the
backend. This CL updates the SyncInformation type to reflect that.

R=alexrudenko@chromium.org, jacktfranklin@chromium.org

Bug: 1245541
Change-Id: Ieee32d961c4d09c64e4fc106c499e69d254c38df
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234188
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-20 14:10:44 +00:00
Yang Guo a5254a82d0 Consistent checkbox styling for adorner settings in dark theme 
Fixed:1249802
Change-Id: Iea47441217546262b6533c0c46091fb3b21bc9b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234191
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-10-20 13:08:04 +00:00
devtools-ci-autoroll-builder d72a0e9dd4 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/d50a437..3ab5542

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1efe7c7..b6ce244

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ifa270a1728d6e83b589f8e7d0400996250483ea6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234251
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-20 12:41:35 +00:00
Johan Bay f32ec387e8 Use recommended sequence to escape script in literals 
See https://github.com/whatwg/html/issues/7179

Bug: none
Change-Id: Ida622dfa42b319a27a399d780b0639503e7653a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3231277
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
 2021-10-20 12:19:03 +00:00
Jack Franklin cd56e74aeb Fix release notes border color & hover 
Swapped to using border for hover so that we use an appropriate color in
both light and dark mode.

Fixed: 1253749
Change-Id: Id493a4e438580c4956ecb5b215d35bbfc7cc04f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234189
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-10-20 12:02:06 +00:00
Alex Rudenko 14d40878ec Update DevTools Chromium DEPS. 
Manual roll disabling a test that regressed due to some
changes in Chromium. Suspecting https://crrev.com/c/3228724

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: 1261763
Change-Id: I6396a009353d003320fa99f487725408d568d4eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234176
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-10-20 11:56:56 +00:00
Benedikt Meurer 277ee38b07 [console] Include column numbers in formatted errors. 
In particular for minified JavaScript, having easy access to the column
number is crucial for debugging, and V8 already provides the column
information for errors, we just removed it so far when we pretty printed
the error stack.

Before: https://imgur.com/Y6uDiUy.png
After: https://imgur.com/0BWpQUD.png
Fixed: chromium:1073064
Change-Id: I3e26115ed129139f6e57eb07fda179d495cc848a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234177
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-10-20 11:23:04 +00:00
Yang Guo c621aa6c18 Fix button overlap in Sensors panel via margin 
R=mathias@chromium.org

Fixed: 1261403
Change-Id: Ie4bef1f42e14ca21cab2f486c58c3c01f0843f3a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234185
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-10-20 11:14:17 +00:00
Yang Guo 1019f93130 Improve color contrast for animation playback rate 
R=mraz@chromium.org

Fixed: 1239598
Change-Id: I1f62a84fdcfe0ad998e97199304329b116e10a31
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234178
Reviewed-by: Mraz Marian <mraz@chromium.org>
Commit-Queue: Mraz Marian <mraz@chromium.org>
 2021-10-20 10:30:43 +00:00
Yang Guo bbfede9946 Give fields for custom keybinds more space 
When the DevTools window is very narrow, keybind fields could be
truncated to the right. By giving it more space, the keybind field
no longer gets truncated, and narrowing the window will bring up
a horizontal scroll bar.

R=jobay@chromium.org

Fixed: 1257105
Change-Id: I66531952b56cd7b3122fe3d9e794c57d36b7a47a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234186
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-10-20 10:14:05 +00:00
Jack Franklin 1234bebd62 Fix focus style for selected tab 
By applying the styling on focus-visible, we ensure that the color
doesn't change when the user clicks (which is confusing, as it doesn't
match the usual selected color), and instead only apply it when the user
tabs (which we want, so they can see where their focus is).

Fixed: 1258571
Change-Id: I94023d7e25cfbe25a12c62edadd77c91cb35b171
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234187
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-10-20 10:11:43 +00:00
Simon Zünd f1815228af Allow SettingCheckbox to be disabled 
This will be used by the sync settings in case the current Chrome
profile hasn't set up Chrome Sync.

R=alexrudenko@chromium.org

Bug: 1245541
Change-Id: I6fdca793fda9fcb8a0257591e5495afabe00120d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234184
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-10-20 09:14:13 +00:00
Wolfgang Beyer 13ae8b5056 [bfcache] Add question mark icons with explainer text 
Bug: 1257120
Change-Id: I9cbd0c4a93b2f05266c51148cbcb1b2bd39b57b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3226460
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-20 08:37:21 +00:00
Kateryna Prokopenko 37b4e77879 Install tooltip for Time cell subtitle for large 
request rows in Network panel

Bug: 855170
Change-Id: I55efba71462eeb1b020ff0ac1ab835991631df2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3231276
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-10-20 07:25:03 +00:00
ergunsh 9cbd6c9453 Add shortcut to search panel for expanding/collapsing all files 
Originally, the feature request is only for expanding all the
files. Since the implementation is trivial and the shortcut is
already ready for collapsing functionality, I decided to add
collapsing as well.

I have chosen "Ctrl + Shift + }" for expanding and
"Ctrl + Shift + {" for collapsing.

Bug: chromium:1255073
Change-Id: I4e8ff3cf82b532346acb1ac6c247f0f361477287
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3212515
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2021-10-20 06:11:17 +00:00
devtools-ci-autoroll-builder 04abb03f2e Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/ea40685..d50a437

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/650f853..1efe7c7

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ie7efb59e3f64d558ae0cb87e7b071d61454d462d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3233800
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-20 03:49:17 +00:00
Brandon Walderman 666b40a5b6 Add column number to linkified sources in the performance panel 
This changes updates the Linkifier with an option to include the column
number in the link text if available. Also taking the opportunity to
remove some run-time type checks that are no longer needed thanks to the
TypeScript migration.

Including the column number in source links helps developers who are
looking at a performance profile "offline" find the function that was
called within the source file. When only a line number is given, this
is more difficult, especially for minified JavaScript files where there
may be many function definitions on the same line.

Bug: 1252049
Change-Id: I1e33583010c8f5d62789e4341ca5b4f6b2c9cd58
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3176625
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-19 21:03:44 +00:00
Maks Orlovich c6100b832a DOMDebuggerModel: small refactor of title setting 
Make setting of titles for instrumentation breakpoints more
table-driven to reduce code duplication and to make adding more
items easier.

Change-Id: Idfc6534d598e8fb1a34a428e3de113916a6a8b8e
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3231935
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
 2021-10-19 18:38:02 +00:00
Wolfgang Beyer 8245fc910c Prevent forced white color for icons in RequestHeadersView 
Don't force white icon colors in the RequestHeadersView's TreeOutline.
Drive-by: fix buggy private field caused by underscore migration.

Fixed: 1151312
Change-Id: I0eded40cfa23dcbcaef926f9f56dd1d623c794ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3231275
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-19 14:13:43 +00:00
devtools-ci-autoroll-builder e7f7eaaddc Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/491911e..ea40685

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I993f2d571c8e341f83895505292a8120fca78132
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3230848
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-19 12:39:53 +00:00
Simon Zünd 1de7cf8f39 [settings] Refactor settings rendering code 
This CL refactors how the sections of the "General Settings" tab are
built. The existing code does 2 passes:
  1) It creates a container for each setting category
  2) It iterates all settings appending them to the correct container
     depending on the settings' category

The new code builds each section in one step by filtering all
settings that will end up in that section.

This refactoring is necessary to allow an easier transition to
web components. Instead of incrementally adding settings to a
component causing many re-renders, we can initialize and render
a future section component in a single step.

Drive-by: Rename `addSettingUI` to `addExtensionsSection` given
what the code actually does.

R=alexrudenko@chromium.org

Bug: 1245541
Change-Id: I93e2b68dbb945a3ede5a8ded9da5ad88fd434fb5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229763
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-10-19 11:32:03 +00:00
Alex Rudenko 1bef13ab30 Implement disabled state for buttons 
This CL implements disabled state for the standard
buttons according to the design spec.

Screenshot: https://i.imgur.com/RzdbcbN.png
Bug: none
Change-Id: I59cc06ed38a156194ddee54828aeec43f481139f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229503
Reviewed-by: Peter Müller <petermueller@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-10-19 10:53:42 +00:00
Wolfgang Beyer fd6bce7310 Remove duplicate experiment and keep only one copy 
The experiment was renamed to not contain a sensitive term.
Previous CL: https://crrev.com/c/2601481
Disable blink test CL: https://crrev.com/c/3226371
Update blink test CL: https://crrev.com/c/3229606

Bug: 1161439
Change-Id: If03ed75b6aaee77802bef14cc81354a4674744ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229507
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-19 10:13:13 +00:00
Kateryna Prokopenko 6b831e3f67 Retype incorrect types from UrlString to RawPathString 
Bug: 1253323
Change-Id: Ie1c0504db44583b39d3c9df4cb971e573f6d332f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229762
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-10-19 09:36:51 +00:00
devtools-ci-autoroll-builder da51040f6b Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/af3a4b4..491911e

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/a9bc3e2..aa2fb01

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I4d1375de51d06bd9fffb30e42515f36548146d4d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3230567
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-19 03:39:08 +00:00
Michael Liao 85fa8e5831 [Accessibility]: Removing aria-hidden attribute from data grid header table 
Issue:
- Data grid headers are not compatible with MacOS Hover Text feature

Changes:
- Removed aria-hidden from the header grid table

Notes:
- This will regress the issue resolved in this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1965851
- The main issue is that the legacy DataGrid component contains two tables, a header table used for sorting and a data container table which is populated with all the data.
    - Since the header table is technically a separate table, the data container table contains a hidden header row (set to height: 0px) so that screen readers can give context to which column each cell is under.
    - To prevent screen readers from traversing both the header table and the hidden header table, resulting in the headers being read twice, the visible header table was marked aria-hidden.

Justification:
- This CL removes the aria-hidden from the visible header table, re-introducing the bug where table headers are read twice as a trade off to support other accessibility tools.
    - It is better to fix a broken experience for one accessibility tool at the cost of slightly inhibiting the usability of another accessibility tool.
- In general, this is an improper use of aria-hidden as it is a visible element that we are intentionally hiding from screen readers as a workaround to support the two table system.
- The new data grid component does not have these issues, so this will just be a temporary bandaid until the new data grid component finishes rolling out.

Bug: 1257739
Change-Id: Id7a0f434153297f27e5df0023c8aba733db85390
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3213089
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
 2021-10-18 17:05:39 +00:00
Simon Zünd 11bc35c1c5 Add SettingCheckbox component 
This CL adds a small web component that binds a checkbox to a boolean
setting. Similar to the legacy element, the binding of the new
component works both ways. Updating the setting updates the comopnent
and clicking the component updates the setting.

The CL also switches the settings UI to use SettingCheckbox.
Please note that the old element is still widely used e.g. in
toolbars or inline configuration of the console.

R=alexrudenko@chromium.org

Bug: 1245541
Change-Id: I256315e0c693edd9d5d3ecf081ff478c78b6badc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229277
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-10-18 14:46:38 +00:00
Nancy Li ba25ddde1d [Quick Open] Fix the filteredListWidget display issue in narrow window 
Before: https://imgur.com/a/777Rmk6
After: https://imgur.com/a/bHGdh3n

Fixed: 1257053
Change-Id: I54db71e696eb9667ff9520993c2da9a83ecf3d7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3226578
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2021-10-18 13:07:18 +00:00
devtools-ci-autoroll-builder d6d55d22ed Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/18d3f4b..af3a4b4

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I094e9902d539b7fcf39d430919252ff0e1750cf6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229385
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-10-18 12:46:09 +00:00
Benedikt Meurer 8e8191e0aa Use breakpoint markers in the Breakpoints sidebar panel. 
Before: https://imgur.com/x9OzRnA.png
After: https://imgur.com/p9AcgjF.png
Fixed: chromium:1148260
Also-By: alexrudenko@chromium.org
Change-Id: I43b9a09fc1e8dd052972950924418cb78666466b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229276
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2021-10-18 11:51:32 +00:00