zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 20:11:38 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,691 Commits 43 Branches 79 Tags
7cf7079ca2fa0bb24861fbcd46aedaaba426a448
Commit Graph
12691 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jaroslav Sevcik 7cf7079ca2 Ignore closed-connection errors in uknown messages 
Chromium newly sends an error after receiving a message for unknown
session ID. This patch ignores unmatched responses if their error
code corresponds to the unknown session ID error.

Bug: chromium:1324237
Change-Id: Ia58a5c39d398aa68a4802d6afdad205686c5969f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3637997
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2022-05-11 07:20:32 +00:00
devtools-ci-autoroll-builder 6f7112d845 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/0c23713..1c34f36

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cb2cef9..31bfd51

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I267fd1fd840b9be5d497995a42f4aae681a5819e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641115
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-11 03:44:31 +00:00
Kent Tamura 9688552c89 Remove the deprecation message for SelectionAddRangeIntersect 
The corresponding Chromium change:
    https://chromium-review.googlesource.com/3631043

Bug: 353069, 1320361
Change-Id: I03b6d7e8ebfd582ed4960d0f6070a8412d2d2e1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3636620
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
 2022-05-11 01:24:31 +00:00
Adam Raine e3940b051c Center Lighthouse screenshot overlay 
Bug: null
Change-Id: I5d27424698a7474a1ed18e17551f0f2703930d0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3639664
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2022-05-11 00:02:01 +00:00
Paul Irish 9d89967044 [Lighthouse] Roll Lighthouse 9.6.0 
Bug: 772558
Change-Id: I3264b8ea518edd305d4ef996a98b6384547807b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3639625
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Adam Raine <asraine@chromium.org>
 2022-05-10 21:08:41 +00:00
Wolfgang Beyer ecdb1c9323 Add sandboxed FileSystem to hosted mode (enables using local overrides) 
Adding a sandboxed file system via `window.webkitRequestFileSystem` to
hosted mode enables using local overrides in hosted mode. Since e2e-
tests run in hosted mode, this enables adding e2e tests for local
overrides. This CL adds a first such e2e-test testing a simple response
header override.

Bug: 1313436
Change-Id: I6eb3e2ff9de336fa62648647fe48042009743d18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3620364
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-10 15:03:01 +00:00
devtools-ci-autoroll-builder 46d6a82d34 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/256e629..0c23713

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1bc3cd2..cb2cef9

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I34dfc7195fc0157a3d02382e9c8cd283958a4147
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3635173
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-10 12:49:11 +00:00
Kim-Anh Tran 236603bacb [BreakpointManager] Make removing breakpoints awaitable 
This CL removes a race that may happen if PersistenceImpl tries to
move a breakpoint from one UISourceCode to another UISourceCode by
explicitly awaiting the calls to remove/setBreakpoint in
PersistenceImpl.

The race happens in the following case (affecting snippets):
* A snippet is created, and the user sets a breakpoint and reloads
  the page.
* PersistenceImpl.ts will try to move the breakpoint via
  1. removing the breakpoint from the old UISourceCode, and
  2. re-setting the breakpoint on the new UISourceCode.
* Simultaneously, the BreakpointManager tries to set a breakpoint
  on the new UISourceCode
* For snippets, the url stays the same after reloading, and in some
  cases the `setBreakpointByURL` of the PersistenceImpl and the
  BreakpointManager will be sent to v8 one after another, such that
  v8 returns a ServerError, as it has already set the breakpoint
  previously

This race causes the breakpoint to completely disappear, since
DevTools front-end removes the breakpoint if it sees a ServerError.

Drive-by: Added additional clean up step to tests.

Bug: 1280621
Change-Id: I7c9cd94c02d80661100cc5c5141e7d0dbb027f6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3629862
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2022-05-10 10:13:21 +00:00
Simon Zünd bbf29481e7 [l10n] Fix deprecation issue messages 
The CL https://crrev.com/c/3613872 applied some weird formatting to
the UIStrings object of DeprecationIssue.ts. This then caused the
strings to be no longer collected by our l10n infra (the CL removes
them from en-US.json).

This CL fixes that by turning off clang-format in that file and let
the PRESUBMIT script re-populate en-US.json with the UIStrings from
that file.

We have not yet imported these strings into the TC, so we were
lucky in catching this early.

Bug: None
Change-Id: I05b9faca446e19ff57ef3eccd04e919234797f8d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3635181
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2022-05-10 09:24:51 +00:00
evliu 3e5dcaba5b Add deprecation warning description for textToSpeech_DisallowedByAutoplay 
This CL adds a deprecation warning description for textToSpeech_DisallowedByAutoplay.

Bug:1320363
Change-Id: Ice5d9fdf91222eb6dbd41800dc114f43ac51de69
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3636777
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
 2022-05-10 08:01:53 +00:00
Alex Rudenko d1dc4e121a Roll Puppeteer to v14.0.0 
Bug: none
Change-Id: I9ba5475355392baa3ab8dd0049fe2d82ec521142
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3634499
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
 2022-05-10 07:43:21 +00:00
devtools-ci-autoroll-builder 72bf664072 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/5478108..256e629

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6a1494e..1bc3cd2

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I7132f6d951e45adfae7f8b3700470f423148d72d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3637019
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-10 03:47:29 +00:00
Jack Franklin d7508305f9 Enable ESLint rule for LitHtml.LitTemplate 
Bug: 1320753
Change-Id: If7e442d3250508c9be9199f1706e73847782197d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3629865
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-05-09 15:06:40 +00:00
devtools-ci-autoroll-builder df558b1579 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/9c02936..5478108

Rolling buildtools/linux64: git_revision:53ef169800760fdc09f0773bf380fe99eaeab339..git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: If24e76cb378b9eab126a223ccd1c9916893a6709
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3634307
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-09 12:52:50 +00:00
Jacky Hu 910a784260 Fix scroll Element into view feature in CSSOverview, Font-info 
Previously, the button, scroll element into view is broken, and UI has
overlay.

This CL
1. Fix button scroll element into view feature.
2. Add style to improve UX (see screenshots).


How to test (or see video record):
1. Go to twitter.com
2. Resize Chromium window to smaller height
3. Open devtools and generate CSS Overview report
4. Go to "Font info" -> scroll to "line-weight" -> select "16px" item
5. Hover on first row and click the button on the right side
6. Twitter page should scroll to bottom, to target Element

Video record:
- https://www.youtube.com/watch?v=rhTwLUiMbss

Before vs After screenshot
- https://imgur.com/a/Z4s0KoB

Bug: 1321076
Change-Id: I9069fd789ef820411ec0ece3f6efb24d84247119
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3631623
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-05-09 11:14:30 +00:00
Henrik Boström 63bb96761f Update DeprecationIssue.ts to cover several WebRTC deprecations. 
Bug: chromium:1318864, chromium:1318860, chromium:1318861, chromium:1318863, chromium:1318876, chromium:1318875, chromium:1318873, chromium:1318874, chromium:1320358, chromium:1320360
Change-Id: Ia17e6b6e7a7e39bc2c5cae5cf94fcef1bc8937c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3607833
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
 2022-05-09 10:09:20 +00:00
Andres Olivares b2084edb02 Remove console.log statements 
They sneaked in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3621873

Bug: none
Change-Id: I5e07e1835c7d96f6304fa2b2f178cecb7253f3b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3631609
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2022-05-09 07:41:50 +00:00
devtools-ci-autoroll-builder 7e675bfce3 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/7b99cdb..9c02936

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I003517ac0776b8948871c6544af60e0844cd2f6c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3633995
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-09 03:58:21 +00:00
devtools-ci-autoroll-builder e9cff61a58 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/3606e28..7b99cdb

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I89c799a9cbb5934183921fe917ae8cf12b9d8282
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3633409
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-07 12:51:49 +00:00
devtools-ci-autoroll-builder 9d390b9965 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/129f40a..3606e28

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ie8eab4c9823cbff4d5af6822f7101a4a49d0c377
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3632679
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-07 04:25:48 +00:00
Alex Cooper 1fcf6cf344 Add deprecation description for xrSupportsSession 
Fixed:1320365
Change-Id: Ibba097a4b0465f7a98d7f808e847a746ac5a74ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3631599
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
 2022-05-06 18:12:30 +00:00
Andres Olivares f2faa9d72d Disable flaky pseudo-states e2e tests 
Tests have failed on recent CQ runs in all platforms. It's worth noting that failures were all caught on release builds.

Mac
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815098232361232049/+/u/E2E_tests/stdout

Win
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815206380887210001/+/u/E2E_tests/stdout

Linux
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815165899262442401/+/u/E2E_tests/stdout

Bug: 1280763
Change-Id: Ie7a60aa175507befae9031cb9daf8f425619a25b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627735
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2022-05-06 15:23:08 +00:00
Nina Satragno nsatragno@chromium.org 519350816e [WebAuthn] Add large blob toggle 
Add a toggle that enables / disables large blob support for WebAuthn
virtual authenticators. This feature has been long supported by the
devtools protocol but we hadn't surfaced it on the front-end.

Large blobs are only available for resident-key enabled authenticators,
so we disable the checkbox if that option is not selected. Also, large
blobs require CTAP 2.1.

Fixed: 1321803
Change-Id: Ic1654276ba5a39ddd8943cd8689978117546e70e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3625237
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
 2022-05-06 14:35:08 +00:00
devtools-ci-autoroll-builder 199649df5c Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/813a2d7..129f40a

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b9dca86..6a1494e

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I04b76bf9e02ee96631c83fe3ee56454818ee67fa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3630507
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-06 13:25:38 +00:00
Wolfgang Beyer 2390df881c Fix another flaky e2e-test in network_test.ts 
Bug: 1093287
Change-Id: I99ce4fe42839a77f6b56a8b2fea7a28df0ceb713
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3629858
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-06 11:43:38 +00:00
Wolfgang Beyer 57f2920874 Fix flaky e2e-tests in network_test.ts 
Bug: 1093287
Change-Id: I2b9c91b78f9f2e7e42091786ad11013dffdc5cbf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3629778
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-06 11:37:20 +00:00
Kateryna Prokopenko 6fa122c18f Type all path and URL variables in panels/timeline to Branded Types 
Bug: 1299788
Change-Id: I7ec964e36b7a50e009d3062fb959dc457fceb339
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627335
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-05-06 11:14:18 +00:00
Kim-Anh Tran e805dda363 [e2e] Re-enable source map test 
This increases the timeout for the source map tests.

Fixed: 1321567
Change-Id: I7871b049bf7ad76f953e9b5205510c81f4d412e5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627770
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2022-05-05 19:13:01 +00:00
Jacky Hu f20648d7e2 Disable Lighthouse Generate report feature when Javascript is disabled 
Previously, user able to generate Lighthouse report when JavaScript is
disabled, UX is bad.

This CL, disable "generate report" feature when Javascript is disabled.



How to test:
1. Go to "www.google.com"
2. Open devtools -> Lighthouse tab
3. Open "Command Menu" and disable JavaScript
4. Check Lighthouse UI, the "generate report" button should be disabled.
   The warning message should show up.
5. Open "Command Menu" and enable JavaScript
6. "generate report" button should be enabled

Screenshots
- https://imgur.com/a/VYPLal1

Video record:
- https://youtu.be/oSMjjMfT4_k

Bug: 1319400
Change-Id: Ibfbae1961bf86c0beedb5d77ceff94152c6e2df3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3622736
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Adam Raine <asraine@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-05-05 16:56:42 +00:00
Andres Olivares 07dca225ab Disable styles pane test on all platforms 
It's failing in windows too:
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815098231520056337/+/u/E2E_tests/stdout

Bug: 1318314
Change-Id: I07e6856b66a26e0cfa18674c026b6f5375a9be9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627734
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2022-05-05 13:17:23 +00:00
devtools-ci-autoroll-builder 308972aabe Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/0c83e78..813a2d7

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/443d913..b9dca86

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Id0f783938bd95af80396c45ae818f628122ca713
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3629123
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-05 12:47:51 +00:00
Kateryna Prokopenko 1e107eb37e Type all path and URL variables in panels/sources to BrandedTypes 
Bug: 1299787
Change-Id: Ie697b75b42bbb75ea95a0c012e29aed1c33796a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627333
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-05-05 11:35:41 +00:00
Ergün Erdoğmuş 5f638bacef Add eslint rule for binding scheduleRender render argument 
Bug: NO_BUG
Change-Id: I64d643a65d0cf4bc3546ed4f75adde7a53c83c4e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3624641
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2022-05-05 11:06:21 +00:00
Wolfgang Beyer 8d9bfd8c98 Prevent visual duplication when assigning file name with special chars 
This fixes the character encoding of the UrlString returned by
`urlsFromParentUrlAndName()`, which is called by `WorkspaceImpl`'s
`renameUISourceCode()`, to match the encoding of filenames as they are
received via `fileSystemFilesChangedAddedRemoved()` from the backend.

Without a matching encoding, the UISourceCode will not be found when
looking it up by URL, which in turn leads to the creation of an
additional duplicate UISourceCode.

Fixed: 1320717
Change-Id: I39a6bda366da3ee681a77f28bb1ad3bcccc86fa5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3613869
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-05 10:08:31 +00:00
Paul Irish d29b1678f6 Performance: Remove FPS track 
The FPS concept is dated and the calculation is flawed

Bug: 1322604
Change-Id: Ie6d14553af78fc0887fefb948496a225aadf3e83
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627074
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-05-05 07:15:31 +00:00
devtools-ci-autoroll-builder 49bb47cb9d Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/c5ff734..0c83e78

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/113378f..7208edd

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/13acea3..443d913

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I03b14a95b4fae9308303f2a6327c1ad0bf7c4a6b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627082
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-05 04:22:02 +00:00
Andres Olivares 2d54e4a35d Disable flaky breakpoint e2e test on other windows 
This test was disabled on mac only, however it has failed recently on
on win too:

https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815165904605034497/+/u/E2E_tests/stdout

Bug: 1321713
Change-Id: Iaf6f095b0888a93b5b28892bd18caf43ed7599f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627736
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2022-05-04 22:30:40 +00:00
Andres Olivares 3ad1a317f7 Disable flaky workflow_test e2e test on mac 
Flakiness examples:

https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815202273940362209/+/u/E2E_tests/stdout

https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815204224733476289/+/u/E2E_tests/stdout

Bug: 1322534
Change-Id: If36fd8c1993a2766cc85e9d527a5d42a188852fa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627999
Commit-Queue: Nancy Li <nancyly@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2022-05-04 17:47:00 +00:00
Andres Olivares f7adffea54 Disable flaky sources tab e2e test on all platforms 
This test has failed recently on other platforms too:

Win:
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815243057646828849/+/u/E2E_tests/stdout

Linux:
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815218728513982881/+/u/E2E_tests/stdout

Bug: 1321898
Change-Id: I839e665f22113a6088842ba40537239bb3466883
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627737
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2022-05-04 17:17:30 +00:00
Andres Olivares 5cae797b18 Disable flaky elements/sidebar-event-listeners e2e test 
Has flaked recently on linux

https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815243055983302049/+/u/E2E_tests/stdout

https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815201771834262833/+/u/E2E_tests/stdout

Bug: 1322533
Change-Id: I4e33cb1e20f12f6d8cf9417b840d23b76603c95a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627997
Auto-Submit: Andres Olivares <andoli@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-05-04 16:59:30 +00:00
devtools-ci-autoroll-builder 49ae10d02a Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/c812b8d..c5ff734

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I400192e49892f2b7629670f736228801aa09754b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3626520
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-04 13:25:30 +00:00
Jack Franklin 8b5339f389 Remove deepActiveElement from prototype 
Now the upstream layout tests have been updated to use the new platform
utility, we can remove the prototype extension.

Bug: 1050549
Change-Id: I1eecbd478b4dc5daf156cf732307a921c7d526e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627331
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2022-05-04 11:59:20 +00:00
Jack Franklin aa70334697 Script to reformat js/ts files with clang-format 
During my work to update JS import wrapping, I wrote up a hacky script
to auto-run clang on all JS and TS files. This CL is that script, but
tidied up and made a bit neater. I think it's worth landing as I can
easily imagine us needing to use it again in the future if clang
releases new config options we want to apply.

Bug: none
Change-Id: I43240c0ffab912d77950cb76540ccdfe8fed556c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627330
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-05-04 11:37:00 +00:00
Andres Olivares 5aa9a8541a Deflake snippets e2e tests 
These tests were reenabled recently in a deflake attempt at https://crrev.com/c/3596912. However, the tests remained flaky on the mac_relase bot. This is another attempt to deflake it. I ran 100 successful consecutive execs of each test with this CL's fix applied in the mac_release bot at https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8815139412446297793/+/u/E2E_tests/stdout, so it is with greater confidence that it's deflaked this time

Bug: 1198160
Change-Id: Ib2d64de93a242cfa3caddae2b749ef50a35d2497
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3621873
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2022-05-04 09:51:02 +00:00
Benedikt Meurer 4cf9a8553f [e2e] Fix flakiness due to not waiting for Call Stack to update. 
Fixed: 1321707
Change-Id: Ib56cdbe889d07e148bceacc4a86f8b1abee0273e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627329
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2022-05-04 07:18:40 +00:00
Jaroslav Sevcik 04a58f2837 SourceMapManager: resolve relative urls with frame's URL 
Instead of trying to set inspectedURL for child targets (which might
confuse extension server), we just lookup the containing frame's url
locally in the source map manager whenever we need it for resolving
relative paths.

This might flush race problems (because inspectedURL is set
asynchronously after receiving getResourceTree response), but such
problems were there before. They are not easy to fix without
redesigning how we index source maps in source map manager's
internal data structures (and they are even harder to repro
and test).

Bug: chromium:1305475
Change-Id: I9e9b67ca1353b4707542f3931db0aef821c00f41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3613885
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
 2022-05-04 06:44:09 +00:00
Xiaocheng Hu 0d4be18861 Add description for Event.path deprecation message 
Fixed: 1320338
Change-Id: I3b9d24abb4a01ebf3a2df644b1f908c0529fb439
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3624905
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-05-04 05:55:10 +00:00
devtools-ci-autoroll-builder f073f6073e Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/0b02492..c812b8d

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e06e307..13acea3

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I85dc559167ec313ffdb7b4235eae44dee849ac36
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627069
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-04 03:39:49 +00:00
Paul Irish 0567b73fec Performance: Trace the default categories when Show All Events 
experiment is enabled.

Currently, this experiment reveals a few more events that
were not allowlisted. But this change will expand the tracing category
selection to all non-high-overhead categories.

Driveby: fix undefined property exception.

Change-Id: I236aad44e40724d82d8c37055686e03148059d2b
Bug: 1321307
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3616460
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2022-05-04 00:10:58 +00:00
Paul Irish a062a6afd7 Network Timing: Drop 'TTFB' from Waiting timing label 
The timing here isn't congruent with the TTFB metric

Bug: 1192230
Change-Id: Ic305f06d981eab531b506dede6a7da8b875864cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3260526
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2022-05-03 19:24:38 +00:00