zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
94 Commits
Author SHA1 Message Date
Ergün Erdoğmuş c71550c756 Add UMA for replay speed in Recorder panel 
Bug: 1306756
Change-Id: I24753e4dad52aa1698c3a7a391edc246dfbd7e12
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3624020
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2022-05-13 11:45:23 +00:00
Simon Zünd c61d52fa5c [uma] Add the 'StackFrameRestarted' action 
Backend CL: https://crrev.com/c/3641766

R=bmeurer@chromium.org

Bug: 1303521
Change-Id: I2d7a01df1ddc3695a5e9a83b74ecf5b93d5b06c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3643696
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-05-12 19:10:03 +00:00
Wolfgang Beyer 1016a48de6 Avoid separate function for InspectorFrontendHost.clearFileSystem 
Move `clearFileSytem()` functionality into the `removeFileSystem()`
method. https://crrev.com/c/3620364 which initially added this method
caused console errors because `initializeInspectorFrontendHost()`
iterates over all properties.

Bug: 1313436
Change-Id: I3244f8c976daaf093e95d94e9ddb1074a1f08d5c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641411
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-11 10:38:28 +00:00
Wolfgang Beyer ecdb1c9323 Add sandboxed FileSystem to hosted mode (enables using local overrides) 
Adding a sandboxed file system via `window.webkitRequestFileSystem` to
hosted mode enables using local overrides in hosted mode. Since e2e-
tests run in hosted mode, this enables adding e2e tests for local
overrides. This CL adds a first such e2e-test testing a simple response
header override.

Bug: 1313436
Change-Id: I6eb3e2ff9de336fa62648647fe48042009743d18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3620364
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-10 15:03:01 +00:00
Jack Franklin e839c0cf22 Enable long import wrapping for JS imports 
DISABLE_THIRD_PARTY_CHECK=big clang format run against all files in
front_end and test/

Bug: 1319340
Change-Id: I1fff63cb07544ccd0e3059fc901f9a48ff4af13b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3598879
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-03 10:22:12 +00:00
Jacky Hu 4853b34457 Add Rendering Shortcuts section in setting for Toggle force Css 
preference color shortcut feature

This CL
1. Add "Rendering" Shortcuts section in setting.

2. Add 'Toggle forces CSS prefers-color-scheme color' shortcut feature.
User able to set shortcut, to use it to toggle CSS prefer color scheme



How to test: (video record covered all steps)
1. Go to https://twitter.com/
2. Open devtools -> Settings -> Experiments -> filter "key" word ->
   enable "Enable keyboard shortcut editor"

3. Reload devtools
4. Go to devtools Settings -> Shortcuts -> find "Rendings" secion ->
   set "Toggle force CSS ..." shortcut

5. Execute shortcut and check twitter's UI



screenshots:
- https://imgur.com/a/GCeyVB2

video record
- https://youtu.be/Mx9gqvIzIzU


Bug: 1280398
Change-Id: I9f69a46705d167bc1e1a17f8bfbe3582af8468aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3614398
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2022-05-03 07:52:20 +00:00
Wolfgang Beyer 81477453b5 Fix local override filename handling for special characters 
This CL fixes local overrides for URLs which contain special characters.
When a resource is saved for overrides, a local path and filename are
generated from the resource's URL. Because not all characters are
allowed to be used in filenames, these characters need to be escaped
(via URL-encoding). The most common cases are '?', which is used for URL
query params and ':', which is used for the port number. Both '?' and
':' are not allowed within file names on Windows OSes.

Previously, DevTools was hiding this complexity of encoded file names
from the user by decoding the file names for user-facing strings. This
could lead to unexpected behaviour, e.g. when renaming files for which
the actual filename does not match the user-facing filename. With this
CL the actual (encoded) filename is shown to the user.

Bug: 1308257
Change-Id: I0303af33502e4e5768e0ccdb44d495b6a2b62190
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3579160
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-04-21 14:30:36 +00:00
Kim-Anh Tran f58a83ed9c Reland "Enable synchronization on instrumentation breakpoints" 
This is a reland of commit 1b596f3b4b.

Changes:
1. Gated behind an experiment
2. Removed changes that are currently not used since it's gated
   (i.e. test changes)

Original change's description:
> Enable synchronization on instrumentation breakpoints
>
> This CL introduces the synchronization point for setting
> breakpoints on new scripts using instrumentation breakpoints.
>
> Instrumentation breakpoints will trigger at the first statement
> of a newly run script. Afterwards we wait for all resources
> that we need to set a breakpoint (if one is cached for that
> particular script), set it, and resume.
>
> Note: this will not correctly synchronize the case where we
> just opened DevTools or just created a new target, as at this
> point some scripts might have started running. For this, we
> need to synchronize the Debugger.enable call, which is something
> that is left to take care of.
>
> Bug: chromium:1229541, chromium:1133307, chromium:1300509
> Change-Id: I44e9b053a7cf64cc1f477a68ce9389cd92a1d05d
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470237
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>

Bug: chromium:1229541, chromium:1133307, chromium:1300509
Change-Id: I19553ddac9530fa3ccac6b245a3dd89da88c6d51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3542248
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2022-04-21 07:43:46 +00:00
Yisi 1a73be9f3c Color picker switches to the new EyeDropper API 
The EyeDropper API[1] has been enabled by default in Chrome 95[2]. Using the new API,we can draw colors outside of the Chrome window.

Added the `EYEDROPPER_COLOR_PICKER` experimental flag, the user can turn off this flag to switch to the old version of the color picker.

[1]: https://github.com/WICG/eyedropper-api/
[2]: https://bugs.chromium.org/p/chromium/issues/detail?id=897309#c35

Bug: 1245191
Change-Id: I05f8628322ab5d314cca640fb269b865821f2ae4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3134563
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-04-11 08:57:02 +00:00
Simon Zünd e546712d0c Fix host bindings 
The CL https://crrev.com/c/3565361 added a method to the host bindings
stub to reset the cached stub data. This does not really work as we
explicilty check on the C++ side that the host bindings are fully
implemented.

This CL is a forward fix that moves the resetting out of the
bindings stub. The `#urlsBeingSaved` Map is not cleared, given
that its in-accessible by the outside anyway.

Roll failure: https://crrev.com/c/3564055.

R=dsv@chromium.org

Bug: None
Change-Id: I94fb41ded43540b742883b96b358f3d3b727dfac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3563073
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2022-04-01 11:25:43 +00:00
Simon Zünd d63ffc77ad [unittest] Reset stub host bindings between tests 
Unit tests run in hosted mode which utilizes a stubbed out
implementation of the host bindings. Most host binding stubs are no-ops
but some record invocations in internal state.

This CL resets the stub state before each test.

R=dsv@chromium.org

Bug: 1306830
Change-Id: Id298a8d3b005346967d5c1d9bf1d3beda57be82b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3565361
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-04-01 08:19:41 +00:00
Kateryna Prokopenko f00c5bf1a0 Type all path and URL variables in the rest of core/ to Branded Types 
Bug: 1299774
Change-Id: I01a2bdd3b44b00471a114da8aeb0d1a7a45df4b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3548838
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-28 12:49:47 +00:00
Jack Franklin 4a78035079 Add new enum value for Performance panel 
Bug: 1285262
Change-Id: If10f398560dcb6a329ffa55d8af74acafbf7f95d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3545151
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-03-23 16:33:20 +00:00
Kateryna Prokopenko 2a1b3a93b0 Type all path and URL variables in WorkspaceImpl to Branded Types 
Bug: 1299780
Change-Id: I1dffe6edc834cf5914d48c4e331510b1866f78b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484200
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-22 10:45:29 +00:00
Changhao Han 935ee90b0e Add metrics for copying style texts 
Backend CL: https://crrev.com/c/3529067

Bug: 1268754
Change-Id: I74aac83d85a16e2ed7f39b8b10bfaea6832be382
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3529446
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-03-17 09:28:47 +00:00
Kateryna Prokopenko 380fdfac97 Type all URL and path variables in FileManager to Branded Types 
Bug: 1299780
Change-Id: I65c083c166ea4e57938f14e4d9ff3b96b2c03083
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484197
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-16 17:26:57 +00:00
Wolfgang Beyer 79797e09f4 UMA for opening the sub-panels in the application panel 
Backend CL: https://crrev.com/c/3497545

Bug: 1302922
Change-Id: If93aab2c3eac8063adc6b034ec03109a79a7d41d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3500431
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-03-04 10:35:57 +00:00
Juba Borgohain 2af14943bb Rename SameSiteCookieIssue to CookieIssue 
These changes rename SameSiteCookieIssue to CookieIssue. A follow-up
CL will make the file name change. It rolls the browser_protocol.pdl
from Chromium to DevTools frontend. Removes the compatibility changes
introduced in [1].

DISABLE_THIRD_PARTY_CHECK=changes required due to renaming

[1]: https://crrev.com/c/3478766

Bug: 1254192
Change-Id: I45b86611edfa469238f7f30bf0006556e8f07fd2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3499339
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Juba Borgohain <chromiumjuba@gmail.com>
 2022-03-02 14:20:02 +00:00
Johan Bay 52f5be82ff Add @layer support in styles sidebar pane 
This CL provides support for @layer rules by providing two features:
1. we now separate the matched styles in the styles pane by their layer
to make it easier to see which layer each rule belongs.
2. we provide a layer overview widget that shows the layer tree for the
tree scope of the currently inspected element.

Screenshot: https://imgur.com/a/CxFrKyc

Doc: https://docs.google.com/document/d/1J7mvg-5eFsLhKLRkd7-mwdIxxDgt2fq1lhOTw47Df6E/edit?usp=sharing
Change-Id: I6fbffc7e272303e942af733029059a0a98771283
Bug: 1240596
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484212
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2022-02-25 13:56:51 +00:00
Jaroslav Sevcik f336ccf23d Expression evaluation with sourcemaps (under flag) 
This is a first step towards evaluating expressions with source map
resolution in the console.

This patch only replaces single variables expressions with the name
inferred from the source map. The feature is behind a flag because it is
still far from being usable (e.g., no support for more complex
expressions, auto-complete, partial expression evaluation, fallback UI,
etc.).

Bug: chromium:1297047
Change-Id: I5d4a233f65cf27112c370eeb81c509cd3e14623d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461558
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
 2022-02-16 08:01:52 +00:00
Adam Raine ff80ccb170 Experiment to add a mode selector to the Lighthouse panel 
Currently only includes navigation and snapshot modes, timespan mode
will require further UX changes because the user controls when timespan
mode ends.

Related:
https://chromium-review.googlesource.com/c/chromium/src/+/3456526

Bug: 1291284
Change-Id: Ic5c7c3b1925609de021e625c5095e8bd08348851
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3456629
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2022-02-14 19:02:37 +00:00
Wolfgang Beyer 6e80008cca Add DevTools experiment for response header overrides 
Bug: 1288023
Change-Id: I1a44d3f180062196e51a21e48fd6e8d41c0e2f6c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3430920
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-02-07 14:02:03 +00:00
Changhao Han 4cc9988ac7 CSS Changes: add change indicator in the Styles pane for changed properties 
This is the first step of integrating CSS Changes into the Styles pane.

Screencast: https://imgur.com/a/97Tn4Sj

Design doc: https://docs.google.com/document/d/1jj9I7ANHh06tbCG6TtcZzd7vqa7hoQNWhOBSku5hKjA/edit

Architecture doc: https://docs.google.com/document/d/1zkOWg1OlUYudFjgqMFvZy1HuOCcrHUFho55q94MowtM/

Bug: chromium:1268754
Change-Id: I515ccdf07343eabf1741c1a46085a0a45aa25afc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3404099
Reviewed-by: Johan Bay <jobay@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-01-25 10:51:10 +00:00
Yuzu Saijo 74f95383e1 [bfcache] Add an experiment to show frame tree structured reason 
This CL adds a new experiment on DevTools to show the bfcache blocking
reasons in a frame tree strucuture. This will be enabled by default
once we have all the reasons reported (currently there's a bug where
some reasons are missing).

Bug: 1288158
Change-Id: Id778a8b7320ef7092e280297add40cdd2936a299
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3396918
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
 2022-01-18 12:42:07 +00:00
Tim van der Lippe 6bcbe0f26d Use window.setTimeout to avoid TS errors in VS Code 
R=aerotwist@chromium.org

Bug: none
Change-Id: I632aa0beb0e157197f5c2f982c2082a6d67f87f4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380595
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-11 19:17:48 +00:00
Alex Rudenko a9a491e39a Add Settings.forceGet method 
The new method always bypasses the local cache
and gets the value from the backing store.

Backend CL: crrev.com/c/3302814
Bug: 1273058
Change-Id: I921edf3a4c741261a3823310c6f23b57934a9ad1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302733
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-01-11 10:21:34 +00:00
Tim van der Lippe 2116adf135 Remove Runtime.loadResourcePromise 
`window.fetch` is the modern equivalent.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I979962efe7a8480c5ddbfb9093db6be421dabd03
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3369371
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 10:38:24 +00:00
Tim van der Lippe 2d9a95ce7b Suppress all existing promise races 
To suppress the races, we mark these invocations with `void` per
the instructions of `no-floating-promises`. This explicitly marks
these statements as side-effect promises.

Engineers can later analyze these void statements and determine
whether the promise races are intentional or accidental.

R=jacktfranklin@chromium.org

Bug: 1239617
Change-Id: I6b7a24cf21029d6ff73b112b3e8255ebab8c60ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366467
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-04 16:08:08 +00:00
Wolfgang Beyer b2da5bb358 Allow removal of entries from UMA enums 
`recordEnumeratedHistogram()` needs both the actual bucket and the total
number of buckets. The total number of buckets was previously determined
by `Object.keys(someMap).length`. This prevented us from ever removing
keys from `someMap` since its length would change.
By explicitly adding a `LastValidEnumPosition` we can now safely remove
keys.

Bug: 1278403
Change-Id: Ib256fc2cf54123f596aa9c5525cce2aabe28bec0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3329541
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-12-21 08:42:54 +00:00
Ari Chivukula 8ad687341f [Client Hint Issue] (3) Implement devtools issue {DEVTOOLS} 
Now that third-party delegation via markup for client hints is in M99,
we need to start alerting developers where they use unsupported
features. These features will be expanded and extended as more client
hint features launch.
https://docs.google.com/document/d/1lDEvj8tMeuvUs1HTTqL-44YiI-7ljeQkusM_WhUfIeE/edit

This CL is a part of a series:
(1) Implement devtools issue {CHROMIUM}
(2) Update devtools protocol {DEVTOOLS}
(3) Implement devtools issue {DEVTOOLS}

Bug: 1219359
Change-Id: Ia8aaf05b98894fd32f5aad8f973fcdf774e1634c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3343149
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Rowan Merewood <merewood@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
 2021-12-16 12:12:18 +00:00
Yang Guo e0c66bc191 Remove dead code for DualScreenDeviceEmulated histogram 
R=wolfi@chromium.org

Bug:1125666
Change-Id: Ibb03349f6a4b1379fbd41eaeb54b20786f5e0d9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3329542
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-12-10 15:53:09 +00:00
Wolfgang Beyer 217f023854 Undo enum value removal for UMA histogram 
Removing the enum value caused a but, because DevTools is relying on
the size of the map for reporting to UMA.

I will look into creating a better fix which would prevent something
like this from happening in the future.

Bug: 1278403
Change-Id: I4ce3d10a87147392374148dd3859d88cac9f1183
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3327244
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-12-10 09:16:57 +00:00
Wolfgang Beyer dc4a43902d Add issue for CorsError.InvalidResponse 
Backend CL: https://crrev.com/c/3320301
Screenshot: https://i.imgur.com/84j7bnK.png

Bug: 1272445
Change-Id: I91dd86cc650a3d34ec7a3dcf57cf2f1032b544f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3323172
Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-12-08 16:52:34 +00:00
Wolfgang Beyer afed9f7b21 Add issues for Private Network Access preflight requests 
Screenshot: https://i.imgur.com/UoaIEGM.png

Bug: 1272445
Change-Id: I23eaa0a1d7ccbbbbfca55386a77e666fdfd53e51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3307444
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
 2021-12-03 09:13:18 +00:00
Tim van der Lippe 4f11084e0d Enable no-unused-private-class-members 
With ESLint 8, we can now report unused private class fields. By
enabling this rule, we also found numerous unused fields in our models
and panels, which this CL deletes as well.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I98fef678fd26c06e67d1d8678e9f8f259355940a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310610
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-01 15:29:06 +00:00
Yang Guo 1d553f1ea0 Remove obsolete histograms 
R=changhaohan@chromium.org

Fixed: 1235544, 1125666
Change-Id: Ib5b28a500cea5c37f433d79ede256c61480804ef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306501
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-11-30 14:28:15 +00:00
Yuzu Saijo f4b1333582 [bfcache] Remove the bfcache debugging experiment 
This CL removes bfcache debugging support from the list of experiment,
so that there is no disabling.

Bug:1110752
Change-Id: I989ceae5a70e981be6b031b6837a9a677b1cc9b4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302236
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-11-30 04:47:38 +00:00
Changhao Han 4382b53352 Add option to format diff in the Changes tab 
This CL adds an experimental flag to automatically format code changes
in the Changes tab. This way the minified sources won't show only one
line of diff that's quite hard to trace the actual difference. It also
won't show formatted source as changes any more.

Screenshot: https://imgur.com/a/lIEqUmU

Bug: chromium:1238818, chromium:1268754, chromium:1086491
Change-Id: I0f2636d1bced17f2f9b32f594bf720951fd4e191
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3300359
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-25 09:05:44 +00:00
Kateryna Prokopenko e5f0f5a6c4 Remove casts to RawPathString from IsolatedFileSystemManager 
Bug: 1253323
Change-Id: Ia9d9c99147d3a22fa74c9ec42d6bd6afa3cef588
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3298816
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-11-25 08:17:04 +00:00
Simon Zünd 7b7b35e178 Revert "Remove V8 Runtime call stats experiment and corresponding code" 
This reverts commit 5a4048ceb0.

Reason for revert: Functionality will stay around.

Original change's description:
> Remove V8 Runtime call stats experiment and corresponding code
>
> R=​alexrudenko@chromium.org
>
> Fixed: 1272432
> Change-Id: Ic4cfa52e7eff3a89c8bb22882d3cc18117c4242b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295525
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: 1272432
Change-Id: I2fca19948a2f1a98123fbd3e8a53b542ee029fb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302099
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-25 07:20:14 +00:00
Kateryna Prokopenko 5404c44e77 Remove casts to RawPathString from IsolatedFileSystem 
Bug: 1253323
Change-Id: I29cb4699b202f5f5c162a8da057c5e457d71cb27
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297840
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-24 09:06:44 +00:00
Kateryna Prokopenko cae13bb94a Remove all DevToolsPath types as some of them might be incorrect 
In order to avoid additional difficulties when typing paths in DevTools
discard the previous (possibly incorrect).

Bug: 1253323
Change-Id: Id4076900a44e9f06440cbfb4b99bed90f1ceb1f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297832
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-11-24 08:51:25 +00:00
Simon Zünd 5a4048ceb0 Remove V8 Runtime call stats experiment and corresponding code 
R=alexrudenko@chromium.org

Fixed: 1272432
Change-Id: Ic4cfa52e7eff3a89c8bb22882d3cc18117c4242b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295525
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-22 13:15:49 +00:00
Alex Rudenko e3c100e5f7 Add UMA for the Recorder panel 
Backend CL: crrev.com/c/3268130
Bug: 1267792
Change-Id: I62857d299b9e6cd9da0ef369554508df23229053
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268285
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-10 07:44:13 +00:00
Ari Chivukula c5440577df [Deprecation Console->Issue] (12) Add metrics (DevTools) 
I forgot to add user metrics for the new issue. Copying the
implementation from: https://crrev.com/c/2692913

This implements the deprecation protocol code per:
https://docs.google.com/document/d/1gU2caqBEek2x8AeKop9SrSxqlO51ipealPMV4aisQNE/edit
https://docs.google.com/document/d/1Jot9P30LFW9TQtc6eaQP9wRBwjLpUn-hIaxRJRUBFvI/edit

This is a part of a set of CLs:
(1) Remove legacy CSS Deprecation path
(2) Consolidate DeprecationInfo
(3) Streamline redundant Deprecation messages
(4) Add features for console/issue deprecation
(5) Fix feature status detail link
(6) Implement Deprecation Issue (Chromium)
(7) Move DeprecationIssue.ts code
(8) Implement Deprecation Issue (DevTools)
(9) Disable Console Deprecation
(10) Remove Console Deprecation
(11) Add metrics (Chromium)
(12) Add metrics (DevTools)

Bug: 1248484
Change-Id: Iebb329365e7cd62589fa3440a9141831ff2d6b92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3265791
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-09 06:27:50 +00:00
Alex Rudenko 3f5d0240c5 Add Recorder panel to UserMetrics 
Backend CL: crrev.com/c/3264196
Bug: 1267792
Change-Id: I14e19c5a3347d6138b9ab8828f13436c6f4f3830
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264217
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-08 09:47:26 +00:00
Benedikt Meurer 6ff672b3c6 [core] Remove debug-only setTimeout(). 
When using --custom-devtools-frontend (or other means that trigger
'debugFrontend' parameter to be set to true), dispatching of browser
messages is delayed via an additional `setTimeout`. This however causes
trouble for example with context menu selection events, where it races
with the removal of the menu item event listeners.

Fixed: chromium:1266826
Change-Id: Idcb0ba5b19854cefcf5a3f8ca2bb2a617ec047e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259698
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2021-11-05 06:41:39 +00:00
Simon Zünd 79bc9f90aa [uma] Record UMA for the sync setting 
We not only record whether the user has opted-in or out for DevTools
Settings sync, but whether Chrome Sync is active in the first place
and if the 'Settings' bucket is enabled. Otherwise DevTools settings
sync will not work anyway.

R=alexrudenko@chromium.org

Bug: 1245541
Change-Id: Ia829133977a3b3e7ff61cfdfd6f9009a46663dfc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3257680
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-04 06:26:50 +00:00
Changhao Han c8c027bd45 Add experiment setting for <length> 
Backend CL for histogram: https://crrev.com/c/3251024

Bug: chromium:1259088, chromium:1172993
Change-Id: I743f1841dd03008f29f7a680e776cde3438831a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3251065
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-10-29 09:50:04 +00:00
Simon Zünd d4f932ff17 [l10n] Remove the localized DevTools experiment 
The localized DevTools experiment has been enabled by default since
M94. With M97, we remove the experiment altogether. Users won't be
affected as English is always the default locale for DevTools even with
the experiment enabled.

R=dsv@chromium.org

Bug: None
Change-Id: I88bedfbcc38b9ace58dfbf3bfa84b4e3214fdebe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240943
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-10-25 10:55:09 +00:00