Ergün Erdoğmuş
c71550c756
Add UMA for replay speed in Recorder panel
...
Bug: 1306756
Change-Id: I24753e4dad52aa1698c3a7a391edc246dfbd7e12
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3624020
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org >
2022-05-13 11:45:23 +00:00
Changhao Han
935ee90b0e
Add metrics for copying style texts
...
Backend CL: https://crrev.com/c/3529067
Bug: 1268754
Change-Id: I74aac83d85a16e2ed7f39b8b10bfaea6832be382
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3529446
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
2022-03-17 09:28:47 +00:00
Mathias Bynens
6dc409767c
Drop support for Chrome 44
...
Chrome 44 was released in 2015-07.
Bug: chromium:1293784
Change-Id: I51a72e32668b14c2fa1aa9d8477b6919f9e70347
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3436426
Auto-Submit: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Commit-Queue: Yang Guo <yangguo@chromium.org >
2022-02-07 12:56:34 +00:00
Danil Somsikov
1f74767043
Option to forbid certain origins for devtools extensions.
...
This is used and tested in crrev.com/c/3429170
Bug: 1115460
Change-Id: I55df48f3d10a0c2163bad068e16bd630ba4b6c8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3428454
Reviewed-by: Andrey Kosyakov <caseq@chromium.org >
Auto-Submit: Danil Somsikov <dsv@chromium.org >
Commit-Queue: Danil Somsikov <dsv@chromium.org >
2022-02-02 13:40:41 +00:00
Alex Rudenko
a9a491e39a
Add Settings.forceGet method
...
The new method always bypasses the local cache
and gets the value from the backing store.
Backend CL: crrev.com/c/3302814
Bug: 1273058
Change-Id: I921edf3a4c741261a3823310c6f23b57934a9ad1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302733
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org >
2022-01-11 10:21:34 +00:00
Yang Guo
e0c66bc191
Remove dead code for DualScreenDeviceEmulated histogram
...
R=wolfi@chromium.org
Bug:1125666
Change-Id: Ibb03349f6a4b1379fbd41eaeb54b20786f5e0d9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3329542
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
Auto-Submit: Yang Guo <yangguo@chromium.org >
Commit-Queue: Yang Guo <yangguo@chromium.org >
2021-12-10 15:53:09 +00:00
Simon Zünd
da9ff39438
[sync] Fix settings sync UMA by adding it to devtools_compatibility.js
...
The "DevTools.SyncSetting" histogram is missing from the host bindings
JS side, so we didn't collect any UMA up until now.
R=alexrudenko@chromium.org
Fixed: 1275456
Change-Id: I4fac223eb5453afd8870c156fbfd8bed4c225e58
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3307448
Commit-Queue: Simon Zünd <szuend@chromium.org >
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org >
Auto-Submit: Simon Zünd <szuend@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
2021-12-01 08:55:25 +00:00
Yang Guo
1d553f1ea0
Remove obsolete histograms
...
R=changhaohan@chromium.org
Fixed: 1235544, 1125666
Change-Id: Ib5b28a500cea5c37f433d79ede256c61480804ef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306501
Auto-Submit: Yang Guo <yangguo@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
2021-11-30 14:28:15 +00:00
Marijn Haverbeke
3ea8755408
Remove machinery surrounding CodeMirror 5
...
The third_party module is still there because a few of its scripts are
used for tokenizing.
R=tvanderlippe@chromium.org
Bug: 1241848
Change-Id: I576b7c1a0fb6c78ca83422fdb9117f169a75efb7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295489
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2021-11-29 15:10:46 +00:00
Alex Rudenko
e3c100e5f7
Add UMA for the Recorder panel
...
Backend CL: crrev.com/c/3268130
Bug: 1267792
Change-Id: I62857d299b9e6cd9da0ef369554508df23229053
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268285
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org >
2021-11-10 07:44:13 +00:00
Simon Zünd
21ec5df2a1
[sync] Add getSyncInformation host binding
...
This CL is part of a chain:
1. https://crrev.com/c/3217452 adds the binding in the backend
2. https://crrev.com/c/3217093 adds the binding in the frontend
3. https://crrev.com/c/3217454 adds a test for the backend CL
The test only works after 2) has landed, so we need to land it
separately.
R=alexrudenko@chromium.org
Bug: 1245541
Change-Id: I99650112219cc3e7af4a55ebaf2608f6a9a20b6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3217093
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Commit-Queue: Simon Zünd <szuend@chromium.org >
2021-10-13 06:33:52 +00:00
Danil Somsikov
f7c7c92719
Record changes to the "Show CORS errors" setting in UMA
...
Bug: 1251176
Change-Id: I078f03153482636dec13e2fa2f207cbb00b7574b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3196174
Auto-Submit: Danil Somsikov <dsv@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Simon Zünd <szuend@chromium.org >
2021-09-30 14:29:32 +00:00
Simon Zünd
2e06713e60
Add 'registerPreference' host binding
...
The host binding was introduced with https://crrev.com/c/3162281 on
the backend side. This CL adds the 'registerPreference' method to
the injected bindings (devtools_compatability.js) as well as the
interface used by the DevTools frontend.
R=alexrudenko@chromium.org
Bug: 1245541
Change-Id: Ica432c14a7d4332c3190af3bf933b6167752839d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3195870
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org >
Commit-Queue: Simon Zünd <szuend@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
2021-09-30 10:29:31 +00:00
Andrey Kosyakov
ad41328d28
Support browser-level connection for service workers
...
- if browserConnection query param is set, assume the default connection
to be the browser one;
- await for initial connection id from the host and attach it;
- use Target.autoAttachRelated on the browser level so that we remain
attached to newer targets even if the original target is gone;
Back-end change: https://chromium-review.googlesource.com/c/chromium/src/+/3114919
Test: https://chromium-review.googlesource.com/c/chromium/src/+/3115848
Design doc: https://docs.google.com/document/d/1udjdBvQNzOLltTM-uZeuu9akU2tgdxgoLji_bX_K_Jo
Bug: 1213714
Change-Id: Ie7363200103a09512e696aa9cf69905982cf4564
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3115448
Commit-Queue: Andrey Kosyakov <caseq@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2021-08-31 19:33:42 +00:00
Alex Rudenko
2f29f1b55a
Remove FixedColor metric
...
The metric has been active for almost a year and we won't probably
need it anymore. This CL removes the instrumentation from DevTools
frontend.
Bug: chromium:1242479
Change-Id: I5ec743cff683a745e2bedbdd7202d87019a58bce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3122336
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org >
2021-08-27 08:40:52 +00:00
Simon Zünd
f6a47f0186
[uma] Record UMA histogram for used DevTools UI language
...
The histogram is recorded right after DevTools is booted up and the
used UI language was determined. The DevTools UI language only changes
in between reboots, so we get exactly one event per DevTools session.
Backend CL: https://crrev.com/c/3115087
R=sigurds@chromium.org
Bug: 1242811
Change-Id: Ib0930eb9bbe7472a061047daedbd107b78ff9800
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3115967
Commit-Queue: Simon Zünd <szuend@chromium.org >
Reviewed-by: Sigurd Schneider <sigurds@chromium.org >
2021-08-26 13:48:55 +00:00
Sigurd Schneider
8fc6f1b872
Remove createElementWithClass from document prototype
...
Bug: chromium:1050549
Change-Id: Ic74b62bae1c416e7b4df909b02f07e8481fe3542
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2998545
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
2021-07-01 10:59:59 +00:00
Benedikt Meurer
55398c049e
[lmi] Implement metrics for the Memory Inspector.
...
Backend: https://crrev.com/c/2720183
Doc: http://docs/document/d/1HJrIWaWnDzXDWhtoGNIus2G-TD9HElWJP4ScLLzE5Rg
Fixed: chromium:1174400
Change-Id: I68c64b029538b048e4eb4c76cb5d7acdc39b7517
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2720239
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org >
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org >
2021-03-02 10:50:47 +00:00
Jesus David Garcia Gomez
76111edfec
Remove option Don't show Chrome Data Saver warning from settings.
...
This CL removes the option "Don't show Chrome Data Saver warning" from
settings because Chrome Data Saver has been deprecated.
Before: https://i.imgur.com/Ggf8hlz.jpg
After: https://i.imgur.com/pSekZs5.jpg
Bug: 1056922
Change-Id: I0ed955e085d96c6bc677b47720994b43040c26cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698373
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
Commit-Queue: Jesus David Garcia Gomez <jegarc@microsoft.com >
2021-02-17 18:44:24 +00:00
Sigurd Schneider
a709974a86
Record schemes of developer resources via UMA
...
Drive-by: Cleanup in user-metrics_test.ts
Drive-by: Cleanup metrics mixup in PageResourceLoader
Bug: chromium:1069378
Change-Id: Icbdf6e533ddc5a99c7684d951cb1afea00846c4c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2637697
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2021-01-20 08:45:41 +00:00
Sigurd Schneider
8d62769d7e
Collect UMA on developer resource loads
...
Bug: chromium:1069378
Change-Id: I324712b50ee50c39620fa76669125f1e3b5e01d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622195
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
2021-01-13 10:48:33 +00:00
Tim van der Lippe
d7cfd14814
Fix no-implicit-coercion errors in front_end/
...
R=jacktfranklin@chromium.org
No-Presubmit: True
Bug: 1082789
Change-Id: Ic77884bf7e9b5dc74053915b3b10699368841b66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2595268
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2021-01-07 12:40:16 +00:00
Wolfgang Beyer
a175e1f23c
[Issues] Add UMA metrics for which types of issues are created
...
The issue code for the various issue types is aligned to follow a
similar schema (except for MixedContentIssues, where there is no
additional info to be embedded in the issue code).
Backend CL: https://crrev.com/c/2574985
Bug: 1072335
Change-Id: I6545297ce38f32f0e4af875c683beac931cdeafc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567967
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
Reviewed-by: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2020-12-15 09:25:17 +00:00
Michael Liao
07a11ed089
[Telemetry]: Adding CSS Editor Opened telemetry
...
This CL adds telemetry for CSS editor openings. The telemetry event triggers when a user clicks on a swatch or the font editor button. The different CSS editors pass in a different ID to differentiate the telemetry events from different swatches/buttons.
chromium/src change: https://chromium-review.googlesource.com/c/chromium/src/+/2410650
Bug: 1149589
Change-Id: I7309591c6fc6ea6524f43a6e3924278446fcf194
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2410431
Reviewed-by: Peter Marshall <petermarshall@chromium.org >
Reviewed-by: Songtao Xia <soxia@microsoft.com >
Commit-Queue: Michael Liao <michael.liao@microsoft.com >
2020-12-08 15:27:43 +00:00
Tim van der Lippe
f52d4a0d1e
Remove remaining unrestricted annotations
...
These weren't found by the regexes used in the previous cleanups,
as their formatting was off. After this CL, no unrestricted
annotations remain in the codebase.
R=szuend@chromium.org
Bug: 1011811
Change-Id: Ief25abab1f981b2315adf61fc56765f2da69fb81
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569760
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2020-12-02 15:41:12 +00:00
Mathias Bynens
a0d60451e1
Remove custom setImmediate implementation
...
All of the existing callsites passed only a callback parameter, with
no additional `args` parameters, and so this functionality is
equivalent to the built-in queueMicrotask().
Note that there are some upstream tests that currently still use
setImmediate. These tests are ported in [1], which should be merged
before this patch can land.
[1]: https://chromium-review.googlesource.com/c/chromium/src/+/2563476
Bug: chromium:1050549
Change-Id: Iee3d286d38bcb17d9b78ca89f9897e8ca37b6d94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2554560
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2020-11-30 14:20:29 +00:00
Changhao Han
45d8473c1a
Remove deprecated CSS Grid UMAs
...
The removed UMAs include:
CSSGridSettings
GridOverlayOpenedFrom
HighlightedPersistentCSSGridCount
Bug: chromium:1138261, chromium:1138260, chromium:1138259
Change-Id: Ic17695b2b5efaff1e5e52d4d0a4e81309c282146
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2562700
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
2020-11-27 12:18:16 +00:00
Peter Marshall
355af6adb9
Add showSurvey and canShowSurvey to InspectorFrontendHost
...
These two methods are used to trigger in-product surveys for new
devtools features.
The two new bindings are added in this chrome CL:
http://crrev.com/c/2509570
Bug: 1112738
Change-Id: Ib44333bf7ca8ac226e7d4e31d6dd51f868144ab3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2361683
Commit-Queue: Peter Marshall <petermarshall@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2020-11-04 07:12:37 +00:00
Changhao Han
429410096a
Remove ComputedStyleGrouping UMA in M88
...
Bug: chromium:1127956
Change-Id: Icee8ad4d5d42c47135563de678d9164e03bdb8a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2485087
Commit-Queue: Changhao Han <changhaohan@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Auto-Submit: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-10-20 11:34:20 +00:00
Changhao Han
03c4838e78
Add UMA for Grid overlays opened source
...
Backend CL: https://crrev.com/c/2410069
Bug: chromium:1047356
Change-Id: I42d4b9e933d6d136b6b6f6da5d312cb25d8eff08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2410229
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
2020-09-16 12:22:07 +00:00
Jesus David Garcia Gomez
0c37bf0f19
[Issues] UMA tracking for the issues panel
...
This CL add new metrics enums to allow measuring when an issue in the
issue panel is expanded and when a resource is opened.
The corresponding chromium CL is at https://crrev.com/c/2305018
Design doc: https://docs.google.com/document/d/1XfVyiQAe9sT9hj0EigQ2skmJP4gCrrnUJVLd-qpFk7A
There are two elements that we can't track the telemetry because
they are stopping the propagation of the event for "click" and
"keydown" if the key is the enter key.
I have open two issues to track them separately.
- Learn More link: https://crbug.com/1108501
- Source link: https://crbug.com/1108503
Summary:
This CL purpose is to answer the question "Which issues are
useful for developers?"
For that purpose this will track when an user expand an issue and
when a resource inside the issue is clicked.
Tracking this two things can help us to answer the previous
question. i.e: "if we see users clicking an issue
but *not* clicking on a resource, that may tell us
the issue needs to be changed or removed"
Bug: 1100658
Change-Id: I4a6f86f107dc710bc64edbf21670a4a3bd2a3d60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2303882
Commit-Queue: Jesus David Garcia Gomez <jegarc@microsoft.com >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Reviewed-by: Sigurd Schneider <sigurds@chromium.org >
2020-09-10 17:13:53 +00:00
Patrick Brosset
77ed48ad21
Grid: New histogram to track how many grids users highlight in the page
...
There is a backend part to this change:
https://chromium-review.googlesource.com/c/chromium/src/+/2379254/
The goal is to track how many grids people highlight in web pages using either
the adorner in the Elements tree, or the checkboxes in the Layout panel.
The histogram is done in a way where we track when users highlight 0, 1, 2, 3, 4
grids, and then between 5 and 9, 10 and 19, 20 and 49, and more than 50.
We have more granularity at the bottom end of the spectrum as the expectation is
that users will mostly highlight few grids at a time.
Bug: 1047356
Change-Id: If3a5282d3909e85ba73b96714fae1d4e2bc9ba36
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2379098
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com >
Reviewed-by: Jose Leal <joselea@microsoft.com >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-09-04 08:48:52 +00:00
Changhao Han
ca13f09d78
Add UMA to track computed style grouping usage
...
Bug: chromium:1096230
Change-Id: I13dd4029ea802b44c2888655f66b45e783663e90
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2392240
Auto-Submit: Changhao Han <changhaohan@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-09-03 06:13:21 +00:00
Paul Lewis
90faf09ce9
Update Closure Compiler and fix associated errors
...
Change-Id: I07cc1ea6b1b135571359136dfdec120ab4649b9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2388060
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2020-09-02 08:41:50 +00:00
Changhao Han
f51d07946b
Add UMA for showing sidebar panes
...
Backend CL: https://crrev.com/c/2378025
Bug: chromium:1119895
Change-Id: I5c24b4b49437cea977bcdddc6327cb3702fa88c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2377585
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
2020-08-27 12:02:55 +00:00
Alex Rudenko
b77998026e
Simplify the grid tooling settings
...
This CL simplifies the Layout settings for grids according to the
latest design.
Screenshot: https://i.imgur.com/g31WbOz.png
Backend CL: https://crrev.com/c/2367833
Bug: 1109177
Change-Id: Ibbba60cc80aa5bc0903ca386e41b6c81fdcd4f0c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2366793
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-08-26 10:45:25 +00:00
Alex Rudenko
3de657afc9
[Metrics] UMA tracking for suggest color feature in Color Picker
...
This CL adds UMA tracking histogram for the new feature of
automatically fixing low-contrast colors to help answer the questions:
- how often is the feature used?
- what contrast threshold is being primarily used?
Backend CL: https://crrev.com/2360069
Bug: 1093227
Change-Id: I3568358e5b26bc63a7c5b569947ccd1d152bb592
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2360010
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Peter Marshall <petermarshall@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
2020-08-20 08:17:24 +00:00
Brandon Goddard
413d17276c
Add histograms for Devtools Experiments
...
This CL introduces 3 histograms around devtools experiments:
ExperimentEnabled - fired when users turn on an experiment
ExperimentDisabled - fired when users disable an experiment
ExperimentEnabledAtLaunch - fires on Devtools launch for each
experiment that is enabled.
These will allow us to gain better understanding of how users
interact with devtools experiments.
Explainer:
https://docs.google.com/document/d/1pcvN11C4onSXqOE0dTjUUHodMj55bRVl_5_e3kMg_rs/edit?ts=5f2329dc#
Corresponding backend CL: https://crrev.com/c/2341215
Bug: 1107636
Change-Id: I4ae72881b6409d25204fea0335f6796161cc61c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2341950
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com >
Reviewed-by: Shane Clifford <shanejc@microsoft.com >
Reviewed-by: Kalon Hinds <kahinds@microsoft.com >
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com >
Reviewed-by: Peter Marshall <petermarshall@chromium.org >
Reviewed-by: Jack Lynch <jalyn@microsoft.com >
2020-08-10 18:13:05 +00:00
Jose Leal Chapa
1e1d958fbd
Logic to log event for panel closed.
...
Re-land the logic to log an event for every panel that is closed.
Backend CL that adds the histogram:
https://chromium-review.googlesource.com/c/chromium/src/+/2259138
This is the previous CL that was reverted:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2259284
Bug: 1074732
Change-Id: Ib92d60cc969c6b10e3bbe9b59f87d52eff8b79ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2303292
Commit-Queue: Jose Leal <joselea@microsoft.com >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2020-08-03 21:09:18 +00:00
Brandon Goddard
ed914d1241
Grid: Update grid telemetry to fire on devtools launch
...
This CL creates a new CSS grid setting histogram to replace the previous
one, which was firing multiple times per setting change. Previously,
the histogram could fire once per target on the debug target page
when a setting changed.
This new histogram fires once on devtools launch, allowing us to
gain insight on user's settings preferences while also filtering
out several events from users quickly trying different settings
before settling on a prefered option
Backend CL: https://crrev.com/c/2304166
Bug: 1106888
Change-Id: I929befb8997ac0908e6c9aa90af509582b77ae49
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2308256
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Shane Clifford <shanejc@microsoft.com >
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com >
2020-07-22 20:25:37 +00:00
Sigurd Schneider
f8d81c4caf
Type histogram name argument of recordEnumeratedHistogram
...
This CL exposed an hard-to-find bug fixed in:
https://crrev.com/c/2275454
Bug: chromium:1098736
Change-Id: Icf512f61854e855566e070cc592af59168d85f08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2278466
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
2020-07-02 08:58:09 +00:00
Sigurd Schneider
7c3f3a6084
Remove legacy support that may crash the DevTools renderer
...
The DevTools renderer crashes if it receives a request to record
histogram data {sample, boundary} where sample is not a non-negative
integer smaller than boundary, or where boundary is larger than the
actual boundary of the histogram in the back-end.
The first call that gets removed falls in to the latter category,
the boundary 100 is way too large. The second call is likely to
trigger the former category, as we currently have ~40 panel codes,
and the hard-coded boundary is 20.
Bug: chromium:1098736
Change-Id: If9c2f13978c130aa8ff5ebe7b421da0c3026c838
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2274511
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
2020-06-30 13:44:20 +00:00
Peter Marshall
76c8758bfd
Remove high resolution profiling option
...
We can just always profile with high resolution.
V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/2198989/
Bug: 1082220
Change-Id: I2d86cc618fdac8138c3cf4463cc5a4436fdb364d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199118
Commit-Queue: Peter Marshall <petermarshall@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-05-18 15:17:22 +00:00
Mathias Bynens
4e1cc676b6
Reland "Enable emulating locales"
...
This reverts commit 012f9c0fc7https://chromium-review.googlesource.com/c/chromium/src/+/2119533
Original change's description:
> Revert "Enable emulating locales"
>
> This reverts commit a36992378fhttps://ci.chromium.org/p/chromium/builders/try/mac-rel/333856 ?
>
> Original change's description:
> > Enable emulating locales
> >
> > This patch adds support for emulating locales through the Sensors
> > drawer. Similar to timezone emulation, it’s tied to geolocation
> > emulation, completing the “user location emulation” feature set.
> >
> > Locale emulation affects:
> >
> > - *.prototype.toLocaleString
> > e.g. `123_456..toLocaleString()`
> > - Intl.* APIs
> > e.g. `new Intl.NumberFormat().resolvedOptions().locale`
> > - navigator.language
> > - navigator.languages
> > - the Accept-Language HTTP header
> >
> > Note that until chromium:1057096 gets fixed, updates to
> > `navigator.language` and `navigator.languages` are not visible
> > immediately, but only after the next navigation/page reload.
> >
> > Changes to the `Accept-Language` HTTP header are only reflected
> > for subsequent requests (but that’s unsurprising).
> >
> > Once chromium:1051186 is fixed, we can simplify the implementation
> > by dropping the call to Emulation.setUserAgentOverride.
> >
> > Boring but useful test/demo pages:
> > - https://mathiasbynens.be/demo/locale
> > - https://mathiasbynens.be/demo/locale#includeExtras
> >
> > Demo video: https://www.youtube.com/watch?v=lZEFwACYPo0
> >
> > Design doc: https://goo.gle/devtools-locale-emulation
> >
> > Bug: chromium:1051186, chromium:1051822, chromium:1057096
> > Change-Id: I0371f450ed23511816941f3a59c14236aea64408
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082371
> > Commit-Queue: Mathias Bynens <mathias@chromium.org >
> > Reviewed-by: Changhao Han <changhaohan@chromium.org >
>
> TBR=mathias@chromium.org ,changhaohan@chromium.org
>
> Change-Id: Iffcacdb304aa107c787266e07dca87cadbe79337
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1051186, chromium:1051822, chromium:1057096
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2116238
> Reviewed-by: Yang Guo <yangguo@chromium.org >
> Commit-Queue: Yang Guo <yangguo@chromium.org >
TBR=yangguo@chromium.org ,mathias@chromium.org ,changhaohan@chromium.org
Cq-Depend: chromium:2119533
Change-Id: I003287fd4524dd88aceac0dbfb7e88e90f26b03f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1051186, chromium:1051822, chromium:1057096
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119672
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
2020-03-25 09:44:42 +00:00
Yang Guo
012f9c0fc7
Revert "Enable emulating locales"
...
This reverts commit a36992378fhttps://ci.chromium.org/p/chromium/builders/try/mac-rel/333856 ?
Original change's description:
> Enable emulating locales
>
> This patch adds support for emulating locales through the Sensors
> drawer. Similar to timezone emulation, it’s tied to geolocation
> emulation, completing the “user location emulation” feature set.
>
> Locale emulation affects:
>
> - *.prototype.toLocaleString
> e.g. `123_456..toLocaleString()`
> - Intl.* APIs
> e.g. `new Intl.NumberFormat().resolvedOptions().locale`
> - navigator.language
> - navigator.languages
> - the Accept-Language HTTP header
>
> Note that until chromium:1057096 gets fixed, updates to
> `navigator.language` and `navigator.languages` are not visible
> immediately, but only after the next navigation/page reload.
>
> Changes to the `Accept-Language` HTTP header are only reflected
> for subsequent requests (but that’s unsurprising).
>
> Once chromium:1051186 is fixed, we can simplify the implementation
> by dropping the call to Emulation.setUserAgentOverride.
>
> Boring but useful test/demo pages:
> - https://mathiasbynens.be/demo/locale
> - https://mathiasbynens.be/demo/locale#includeExtras
>
> Demo video: https://www.youtube.com/watch?v=lZEFwACYPo0
>
> Design doc: https://goo.gle/devtools-locale-emulation
>
> Bug: chromium:1051186, chromium:1051822, chromium:1057096
> Change-Id: I0371f450ed23511816941f3a59c14236aea64408
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082371
> Commit-Queue: Mathias Bynens <mathias@chromium.org >
> Reviewed-by: Changhao Han <changhaohan@chromium.org >
TBR=mathias@chromium.org ,changhaohan@chromium.org
Change-Id: Iffcacdb304aa107c787266e07dca87cadbe79337
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1051186, chromium:1051822, chromium:1057096
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2116238
Reviewed-by: Yang Guo <yangguo@chromium.org >
Commit-Queue: Yang Guo <yangguo@chromium.org >
2020-03-24 19:25:12 +00:00
Mathias Bynens
a36992378f
Enable emulating locales
...
This patch adds support for emulating locales through the Sensors
drawer. Similar to timezone emulation, it’s tied to geolocation
emulation, completing the “user location emulation” feature set.
Locale emulation affects:
- *.prototype.toLocaleString
e.g. `123_456..toLocaleString()`
- Intl.* APIs
e.g. `new Intl.NumberFormat().resolvedOptions().locale`
- navigator.language
- navigator.languages
- the Accept-Language HTTP header
Note that until chromium:1057096 gets fixed, updates to
`navigator.language` and `navigator.languages` are not visible
immediately, but only after the next navigation/page reload.
Changes to the `Accept-Language` HTTP header are only reflected
for subsequent requests (but that’s unsurprising).
Once chromium:1051186 is fixed, we can simplify the implementation
by dropping the call to Emulation.setUserAgentOverride.
Boring but useful test/demo pages:
- https://mathiasbynens.be/demo/locale
- https://mathiasbynens.be/demo/locale#includeExtras
Demo video: https://www.youtube.com/watch?v=lZEFwACYPo0
Design doc: https://goo.gle/devtools-locale-emulation
Bug: chromium:1051186, chromium:1051822, chromium:1057096
Change-Id: I0371f450ed23511816941f3a59c14236aea64408
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082371
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
2020-03-24 12:43:32 +00:00
Tim van der Lippe
d71c22d7ce
Typecheck host/ with TypeScript
...
Hacks, hacks and hacks. These files were very inconsistent in terms of typing.
They now use the proper FileSystem API's (which ship with Closure, but not
with TypeScript).
R=szuend@chromium.org ,jacktfranklin@chromium.org
Bug: 1011811
Change-Id: I46bd59d2f22372157afcdb18871442f51e20e778
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2108763
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2020-03-19 13:14:12 +00:00
Mathias Bynens
f06e8c0758
Enable no-else-return lint rule with autofix
...
This rule matches the Chromium-wide coding style.
Bug: chromium:1057042
Change-Id: I21ad946227ca7344146abace1d2f6146b3a6c207
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078924
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2020-02-28 14:17:07 +00:00
Simon Zünd
1facecf39e
[cleanup] Replace {pushAll} helper with {push} plus spread operator
...
Change-Id: I5c91ff89ff69090db8a3cfaf326a5308d23d6ca7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2003312
Commit-Queue: Simon Zünd <szuend@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-01-16 10:23:34 +00:00
Tim van der Lippe
647e33b2a1
Reland "Implement lazy loading of modules"
...
This reverts commit cc75dee3ba7c08ccfd54https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8897915672067501312/+/steps/browser_tests__with_patch_/0/logs/Deterministic_failure:_DevToolsExtensionTest.TestDevToolsExtensionAPI__status_FAILURE_/0
>
> Original change's description:
> > Implement lazy loading of modules
> >
> > Any module that is not autostart and has `modules` specified in its `module.json`
> > will now have its entrypoint dynamically imported. Update the release build script
> > to output the `modules` array as well so that the Runtime can load it.
> >
> > Add additional entrypoints to `platform` and `dom_extension` to be consistent
> > with the naming patterns of all other modules
> >
> > Bug:1006759
> > Change-Id: If6d10a13a62354079e3f8ee49bee4ecdcffa6758
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1893085
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org >
>
> TBR=yangguo@chromium.org ,aerotwist@chromium.org ,tvanderlippe@chromium.org
>
> Change-Id: I22e8a341e841a99df0df9808a419cc070dd81bea
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1006759
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1893087
> Reviewed-by: Yang Guo <yangguo@chromium.org >
> Commit-Queue: Yang Guo <yangguo@chromium.org >
TBR=yangguo@chromium.org ,aerotwist@chromium.org ,tvanderlippe@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1006759
Change-Id: Id69542e883fc4b852a79e83373773de256976f83
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1897686
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2019-11-04 19:25:35 +00:00
Ergün Erdoğmuş
