zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-22 22:14:39 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 45 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
133 Commits
Author SHA1 Message Date
Jack Franklin f8f7e3524f Expose Platform.DOMUtilities in layout tests 
Required to remove dependency on `deepActiveElement` from
dom_extensions.

Bug: 1050549
Change-Id: I399ca3b23834b56b8d7c797889bec296553054d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3598872
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-04-21 08:40:48 +00:00
Brandon Walderman d97633b637 Use single table for legacy DataGrid component 
This change converts the separate <table> that was used for the
DataGrid's header row into a <thead> section in the data table. This
results in a single <table> element which is easier for screen reader
users to navigate.

The header has CSS position:sticky so that it remains in view when
scrolling through long data sets. To get the cleaner DOM structure,
and ensure scrolling continued to work, I had to set the whole table
to overflow-y: overlay. This means that the scrollbar now extends up
into the header row which is a visual change from before. See before
and after screenshots below.

I looked into setting the overflow property on the
<tbody> element instead, but this would only make the <tbody>
scrollable if the <tbody>'s display was set to 'block'. Doing that
keeps the scrollbar out of the header area as before, but it breaks
the overall table layout and prevents the cells from using the
widths defined in <colgroup>, which means the resizer UI doesn't work.
This could potentially be fixed with more work in the typescript, but
its not clear this would be worth the effort. The change I'm sharing
here trades the small visual regression for an accessibility win with
as little code churn as possible.

Before:
https://imgur.com/a/9ffDg3J

After:
https://imgur.com/a/iPcnaw7

Bug: 1316147
Change-Id: I30638eb512cdf91e9e5b6383bee8eb1289527311
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3586197
Reviewed-by: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
 2022-04-19 20:13:35 +00:00
Yoav Weiss 727b9b4842 Add async GC primitive to legacy BindingsTestRunner 
There are a few tests that are failing on [1] due to their use of sync
GC calls. This CL adds an async GC primitive that those tests would be
able to use.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3310850

Bug: 1291129
Change-Id: I4559fc9ac7b8cb1f7704bfc3c0fa6bd337ffc141
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3516379
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
 2022-03-14 11:11:13 +00:00
Kim-Anh Tran bbb5232d14 Revert "Enable synchronization on instrumentation breakpoints" 
This reverts commit 1b596f3b4b.

Reason for revert: closed the tree, more blink tests to adapt

Original change's description:
> Enable synchronization on instrumentation breakpoints
>
> This CL introduces the synchronization point for setting
> breakpoints on new scripts using instrumentation breakpoints.
>
> Instrumentation breakpoints will trigger at the first statement
> of a newly run script. Afterwards we wait for all resources
> that we need to set a breakpoint (if one is cached for that
> particular script), set it, and resume.
>
> Note: this will not correctly synchronize the case where we
> just opened DevTools or just created a new target, as at this
> point some scripts might have started running. For this, we
> need to synchronize the Debugger.enable call, which is something
> that is left to take care of.
>
> Bug: chromium:1229541, chromium:1133307, chromium:1300509
> Change-Id: I44e9b053a7cf64cc1f477a68ce9389cd92a1d05d
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470237
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>

Bug: chromium:1229541, chromium:1133307, chromium:1300509
Change-Id: I9eccdf065820854746ec7ad4643362859c9960e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3506653
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Owners-Override: Kim-Anh Tran <kimanh@chromium.org>
 2022-03-08 13:45:41 +00:00
Kim-Anh Tran 1b596f3b4b Enable synchronization on instrumentation breakpoints 
This CL introduces the synchronization point for setting
breakpoints on new scripts using instrumentation breakpoints.

Instrumentation breakpoints will trigger at the first statement
of a newly run script. Afterwards we wait for all resources
that we need to set a breakpoint (if one is cached for that
particular script), set it, and resume.

Note: this will not correctly synchronize the case where we
just opened DevTools or just created a new target, as at this
point some scripts might have started running. For this, we
need to synchronize the Debugger.enable call, which is something
that is left to take care of.

Bug: chromium:1229541, chromium:1133307, chromium:1300509
Change-Id: I44e9b053a7cf64cc1f477a68ce9389cd92a1d05d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470237
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2022-03-08 12:08:41 +00:00
Takuto Ikuta 713066b4a9 have another space trimming path to pass blink_web_tests with esbuild 
Bug: 1293756
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_linux_blink_light_rel_fastbuild,devtools_frontend_linux_dbg_fastbuild
Change-Id: I8037954f133e97ae4bf15ac89edec20dfdb4931c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3435632
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-03 13:30:33 +00:00
Mathias Bynens ae6511abf2 Clean up redundant Promise.resolve() in PersistenceTestRunner 
Bug: chromium:1161501
Change-Id: I6280619afa813470af65b819e25edb232da3e701
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3428450
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Randolf Jung <jrandolf@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
 2022-02-01 10:47:22 +00:00
Mathias Bynens 02ed46d348 Clean up redundant Promise.resolve() in HeapProfilerTestRunner 
Bug: chromium:1161501
Change-Id: I2857d20b536fa4d5abd2afd19551ae6d85f89ee2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3428448
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Randolf Jung <jrandolf@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
 2022-02-01 10:36:20 +00:00
Simon Zünd 6a1a3c6c4c [console] Use scriptId for better Error#stack linking 
This CL combines the info from Runtime#getExceptionDetails with the
parsed Error#stack to improve linkification. With the additional
exception details we can link to a concrete scriptId rather then
having to guess the script.

R=pfaffe@chromium.org

Fixed: 1280141
Change-Id: I580a2d824f9d90b6376dfc77c6017d7649d2ceba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3418499
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-02-01 08:09:00 +00:00
Mathias Bynens 9c18c05e12 Clean up redundant Promise.resolve() in legacy Sources test runner 
Bug: chromium:1161501
Change-Id: Ibbff15b2bb8d6b5738471f7e448ee870adcf67f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3427066
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2022-02-01 06:50:02 +00:00
Tim van der Lippe dc32d33674 Cleanup front_end/OWNERS 
After the folder restructure, all legacy test runners are placed in
`legacy_test_runner`. Therefore, we no longer need a blanket star-match
for test runner folders and can move that into the subfolder.

R=yangguo@chromium.org

Bug: none
Change-Id: Ie7e840a35b3371abeae479c2ab98f90af38140bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366664
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2022-01-05 16:02:18 +00:00
Tim van der Lippe 55278a6c23 Remove final few side-effects in platform/utilities.ts 
The final few can be added to TestRunner.js which can expose them to the
global scope for the legacy layout tests. The other usages of the final
global have been removed from the legacy defs and ported in the code.

As such, we can now consider crbug.com/1050549 finalized and all globals
properly exported.

R=jacktfranklin@chromium.org

Fixed: 1050549
Change-Id: I9945ecb15e6324ee1982a81fbab669c63fb62512
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313065
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-02 15:37:43 +00:00
Tim van der Lippe 339872c26f Remove modules support from Runtime 
All of these fields/functions were related to loading the legacy modules
powered by the now-removed `module.json` files. Therefore, we can clean
all of this up, as they are all unused.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iebe807a91415d16ba653a32abe4cd237d5b60bc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313060
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-02 13:27:53 +00:00
Tim van der Lippe 73b8c4f35c Remove entrypoints/devtools_app/devtools_app.json 
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I0d143909fa7bc40368e223b17b3825b97b6ab772
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310865
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 11:26:33 +00:00
Marijn Haverbeke 3ea8755408 Remove machinery surrounding CodeMirror 5 
The third_party module is still there because a few of its scripts are
used for tokenizing.

R=tvanderlippe@chromium.org

Bug: 1241848
Change-Id: I576b7c1a0fb6c78ca83422fdb9117f169a75efb7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295489
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-29 15:10:46 +00:00
Tim van der Lippe 603acd4972 Fix console.table 
The legacy datagrid expects all users of its API to call `.asWidget`,
but doesn't actually enforce doing that. The `ConsoleViewMessage`
wasn't calling `.asWidget`, as it doesn't use a proper widget structure
itself.

Instead, we can manually recreate the widget with a shadowroot boundary,
so that the styles can properly be injected. Additionally, we need
to carry over the `objectValue` styles that `ConsoleView` also injects
in its root.

R=alexrudenko@chromium.org

Bug: 1271191
Change-Id: If9934ef54d51a961d8c0df7f02b96c7d9b0a5b92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3291585
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-18 17:04:29 +00:00
Wolfgang Beyer 492e3aa917 Improve whitespace handling of TestRunner formatter 
Line breaks between tags in LitHtml are rendered as spaces or line
breaks (in Debug builds) in the TestRunner's output. This formatter
replaces cases of 3 or more whitespace characters with a single space.

This will fix the output for the tests activated in
https://crrev.com/c/3275975.

Bug: 1270500, 1268947, 1260776
Change-Id: I9a4c278ef0268c50c15aacb0d1020bb22e30c59c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3284808
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-11-16 15:16:42 +00:00
Kateryna Prokopenko a8c5ba4316 Fix the path check in the filesystem creation callback in the 
IsolatedFilesystemTestRunner.

File system path() is returned as a URL, so we need to convert the
other part of the comparison accordingly.
Dependent CL:
https://chromium-review.googlesource.com/c/chromium/src/+/3279403

Bug: 1253323
Change-Id: If4e4f030864f2b63fe644c4d6eab003a85db48a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3279183
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-11-16 10:48:25 +00:00
Tim van der Lippe b5fb91dfa5 Move legacy file loading to legacy_test_runner 
DevTools startup has slowed down a bit over the last year. The main
suspect that we have is the amount of files that are loaded at startup.
We have historically made significant improvements by removing file
loading out of the critical path, for example by removing the `module.json`
files from various modules. These have all attributed to improvements.

For our shell, we were still loading these legacy files. However, now
that we are fully type-checked with TypeScript, we have for the most part
removed our reliance on globals. There are only a handful of places where
we still rely on globals, most notably `MainImpl` for instantiation of
singletons and a single declaration in `ui/legacy/Panel.ts` which sets
values on `UI.panels`. Other than that, there don't appear to be anymore
usages of globals.

Therefore, we can move these legacy files out of our main shell and into
the legacy_test_runner. Doing so, our production build will now include
fewer files and hopefully also boot faster, while we still load the
legacy files for our layout tests (which still rely on globals).

It isn't clear what the performance impact will be, but cleaning this up
is good and we are relatively confident this will alleviate at least
some of the performance problems that have been reported.

R=yangguo@chromium.org

Bug: none
Change-Id: Ie34fbf6b82f3d1ba11bed623a9cc3d2a03c4c0c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264212
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-11-15 14:39:55 +00:00
Wolfgang Beyer 31477c2149 Enable Testrunner to trim multiple spaces down to a single one 
After adding icons which function as links to console messages in [1],
some tests were failing [2] because the icon components contain multiple
text nodes of a single space character each. These spaces were being
rendered in the test output. This CL adds options to reduce multiple
consecutive spaces down to a single one for test output. The tests
are being turned on again in [3]

[1] https://crrev.com/c/3269837
[2] e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/
  Linux%20Tests%20(dbg)(1)/100288/test-results
[3] https://crrev.com/c/3275975

Bug: 1260776
Change-Id: Id352e137fa2b8d153b3c8031f1c44d8aedb46c8d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3275781
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-11-12 15:01:53 +00:00
Simon Zünd 709b09e63c [test_runner] Use dynamic import directly instead of using eval 
Bug: 1011811
Change-Id: Ia1391e881ba36d6c8a2cb391946d3058e87e816b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259092
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-04 06:25:48 +00:00
Tim van der Lippe 113abecd98 Reland "Migrate to private class fields in models/bindings" 
This reverts commit 550eb43d4e.

Reason for revert: Fixed layout test

Original change's description:
> Revert "Migrate to private class fields in models/bindings"
>
> This reverts commit bad24493c9.
>
> Reason for revert: layout test causing autoroll failures: https://crrev.com/c/3218502
>
> Original change's description:
> > Migrate to private class fields in models/bindings
> >
> > R=​szuend@chromium.org
> >
> > Bug: 1222126
> > Change-Id: I3a6fbea503d3c0fded7208109e0d2b52b1159516
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207879
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> Bug: 1222126
> Change-Id: I47dd7e76d749c8f6503955f23ee9b5e452382ffb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3218891
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Bug: 1222126
Change-Id: I80a7a70264de8236b8da860ff2ecc05b7ae32a85
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3218075
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-12 12:44:28 +00:00
Jack Franklin 550eb43d4e Revert "Migrate to private class fields in models/bindings" 
This reverts commit bad24493c9.

Reason for revert: layout test causing autoroll failures: https://crrev.com/c/3218502

Original change's description:
> Migrate to private class fields in models/bindings
>
> R=​szuend@chromium.org
>
> Bug: 1222126
> Change-Id: I3a6fbea503d3c0fded7208109e0d2b52b1159516
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207879
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: 1222126
Change-Id: I47dd7e76d749c8f6503955f23ee9b5e452382ffb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3218891
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-12 09:14:00 +00:00
Tim van der Lippe bad24493c9 Migrate to private class fields in models/bindings 
R=szuend@chromium.org

Bug: 1222126
Change-Id: I3a6fbea503d3c0fded7208109e0d2b52b1159516
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207879
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-11 15:01:49 +00:00
Marijn Haverbeke 6add435a1f Use CodeHighlighter to highlight CSS/script content in the elements pane 
And drop the CM5-based SyntaxHighlighter.

R=tvanderlippe@chromium.org

Bug: 1215072
Change-Id: Ibd2884fd3d4168e4a446813890d6a0aab878135e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207148
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-10-11 10:14:32 +00:00
Tim van der Lippe f290aeebbc Migrate to private class fields in core/sdk 
R=aerotwist@chromium.org

Bug: 1222126
Change-Id: Ia1301d0a2c9b530ee94c389ca886292a228df13d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3201676
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-10-04 18:11:33 +00:00
Alex Rudenko 53e75c363b Remove AppCache test runner from DevTools 
AppCache is being removed from Chromium in
crbug.com/582750. We no longer need the test runner
which also seems to be unused.

Bug: chromium:1084190
Change-Id: If2db405a9155129d317b5221c221798433a580d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3179141
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-09-24 05:44:14 +00:00
Leszek Swirski 0fcd89728d [test-runner] Allow multiple names in printTimelineRecords 
Allow PerformanceTestRunner.printTimelineRecords[WithDetails] to take
multiple names (as a rest parameter for backwards compatibility with the
single-name version). This would allow tests to test the interleaving of
multiple events, like V8 compilation and cache production.

Bug: chromium:1242848
Change-Id: Ifafa2460f9dcec5c9d839298f6bc991a04a7aef2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3122657
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
 2021-08-30 10:46:34 +00:00
Sigurd Schneider 4434224f87 Migrate dictionary object to Map 
Drive-by: Improve types

Depends on chromium CL: https://crrev.com/c/3110457

Bug: chromium:1172300
Change-Id: Ifaa93dcf6fce52a0c83ead5e195f6a16dde86956
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3113766
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-08-23 15:11:20 +00:00
Jan Scheffler 6d2d73562a Update TestRunner after underscore migration 
Bug:chromium:1207342
Change-Id: I9af3cb4fa580396e5effb7fb74b577e96c088875
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3110377
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-23 14:26:48 +00:00
Sigurd Schneider 1513b30700 Add helpers to ElementsTestRunner to reduce coupling 
This CL adds helpers to ElementsTestRunner to reduce coupling
between the elements panel implementation and web tests.

Bug: chromium:1207342
Change-Id: Ifcfefcd95c1e446dd63b73aa1f86f5a5b914af66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3110202
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-08-23 11:27:38 +00:00
Jan Scheffler 308fa272cc Update TestRunners after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I84b6edec7a4acefecb9dc54abb429b231b0f465f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3110435
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-23 10:00:57 +00:00
Jan Scheffler ed23531005 Update HeapProfilerTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I576428273e25595ea8d45c6ac82802bafa53b6ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3110431
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-20 14:49:28 +00:00
Changhao Han 20932ec7ff Add CSS <length> component in the Styles pane 
Design doc: https://docs.google.com/document/d/12kRAA5yrjGHQJ5CiKR0kOM3xpvkAq1f-qLbbS5SVXYM/edit#

Bug: chromium:1126178, chromium:1172993
Change-Id: I1e6dfb17c7115ddf569b0bfe572de01391b7cedb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3102245
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
 2021-08-20 12:55:50 +00:00
Jan Scheffler 353492a960 Update TestRunners after underscore migration 
Bug: chromium:1207342
Change-Id: I1c2f36feb524d2ea4940552367a16bddb714e215
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3107135
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-19 15:57:16 +00:00
Sigurd Schneider 9e9a51caf3 Update some test runners after underscore migration 
Bug: chromium:1207342
Change-Id: I0ad653fd36421d8e14a013cf8d81cb5c94caffdf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3104561
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-19 13:07:43 +00:00
Jan Scheffler 3249f0e330 Update SourcesTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: Ied87329c2b6c1437a62dcc684d9f9a8ffd319433
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100078
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 15:02:41 +00:00
Jan Scheffler c2af4cbb4d Update SDKTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I3f7c0a00424310e863a07885edff19b22514c3fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100077
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 13:54:11 +00:00
Jan Scheffler 31a79363b7 Update LayersTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: If93accc0fcdcae8a5fcb9d22206e998ec08a9c64
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100074
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 13:51:01 +00:00
Jan Scheffler 37ff5d396a Update TestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I26a6e774731a89594b0effb768ca369031e5cb7d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100079
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:30:33 +00:00
Jan Scheffler 569b522c84 Update NetworkTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I7f5cf5226f865c92017908a8ad8811f54b38230e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100075
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:29:31 +00:00
Jan Scheffler 6550899b0d Update PerformanceTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I20084dad0a2d973dc57b4c07d69f026513fbdf9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100076
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:28:29 +00:00
Jan Scheffler b2bd05855c Update HeapProfilerTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: Ic3d50b4d3ccd336b3c624f0b17a4293bf9e8fc08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100073
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:27:27 +00:00
Jan Scheffler d4f553d873 Update ExtensionTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: Ia291b00c4b3cdd7468b6dd46497f5d9bf581bd21
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100072
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:26:13 +00:00
Jan Scheffler 346c396e74 Update DataGridTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I969b7bc73bfbae6e70d3dacdcb44fcb9ba242e20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100071
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:25:11 +00:00
Jan Scheffler dfbc65dc88 Update CoverageTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I325865cdeb7ba4f02e6ebc6da0a8ce15acb1e78e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100069
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:24:10 +00:00
Jan Scheffler 31efbf14f1 Update ApplicationTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I0f6a2566ca74314be6aefd27822113cfc337f652
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3099997
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:23:08 +00:00
Jan Scheffler 6f27b8879b Update CpuProfilerTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I778c1e732a43f659d3339b7bcb8377efcdabf289
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3100070
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:22:06 +00:00
Jan Scheffler a4192b5d5f Update AccessibilityTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I86b38d4aac01538c34c6c704923575e7da34b23b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3099996
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:21:03 +00:00
Jan Scheffler e382e0dd49 Update BindingTestRunner after underscore migration 
R=tvanderlippe@chromium.org

Bug: chromium:1240590
Change-Id: I2c2c2bb3d6b5f70166ee7e34f5d308915799a264
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3099998
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-18 10:20:01 +00:00