zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-13 10:05:41 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 45 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
40 Commits
Author SHA1 Message Date
Dave Tapuska 16bfd6147a Add handling of isOutermostMainFrame. 
https://chromium-review.googlesource.com/c/chromium/src/+/3625434
added support for isOutermostMainFrame to discern the
outermost main frame from embedded main frames.

BUG=chromium:1314858

Change-Id: I4aa181b2a863050d2153d29108b5d7b826d9053b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627073
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
 2022-05-13 14:31:14 +00:00
Jack Franklin 8920120bff Remove "Interactions=>Input" swimlane in Performance Panel 
Fixed: 1324090
Change-Id: I7eed96829032e45addc9960abf3cb7d538ab12ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3635178
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2022-05-11 11:42:15 +00:00
Paul Irish 0567b73fec Performance: Trace the default categories when Show All Events 
experiment is enabled.

Currently, this experiment reveals a few more events that
were not allowlisted. But this change will expand the tracing category
selection to all non-high-overhead categories.

Driveby: fix undefined property exception.

Change-Id: I236aad44e40724d82d8c37055686e03148059d2b
Bug: 1321307
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3616460
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2022-05-04 00:10:58 +00:00
Andres Olivares 8b58098c83 Restore Interactions lane in the Performance panel 
This adjusts the front end code that draws the lane in the panel to
support the current shape of the LatencyInfo trace events. These trace
events have changed considerably since 2+ years ago.

Note that I have other tests for the data generation at https://crrev.com/c/3594760

The changes in the trace events are documented in https://docs.google.com/document/d/1JRNbKli4TWZZFk3CYhXMcRTQ_69x5YFgmIuna_gcF_E/edit?usp=sharing

Bug: 1317621
Change-Id: I6a9bc585ae38a9f3551bf59c8fe45993543f3adc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3583855
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2022-04-20 15:17:46 +00:00
Andres Olivares 9d8df0f863 Do not register the same layout invalidation twice 
<Warning: long commit message for a simple change to an old and
complicated code.>

This CL prevents an error to be thrown when the performance panel
tries to match `StyleInvalidatorInvalidationTracking` with
`ScheduleStyleInvalidationTracking` trace events. Matching these two
allows to provide more details about the initiators of style
recalculations in the renderering pipeline in a trace, and is part of an
unstable feature implemented eight years ago. Since the its
implementation (in https://codereview.chromium.org/731293006),
the feature is run under a flag for unstable experiments, so the events
in question haven't been fully supported by DevTools to date.

The fix consists in not adding `ScheduleStyleInvalidationTracking`
events as layout invalidations twice. Currently, the events are added
once they are handled from the trace and another time when a
`StyleInvalidatorInvalidationTracking` is handled. When the latter
happens, the style recalculation to which the initiators want to be
added is set to null, as if another frame has started, which eventually
causes the error to be thrown. As such this CL removes the second
registration to prevent the throw.

Finally, the error logged when no match is found for a
`StyleInvalidatorInvalidationTracking` event is omitted as this is a
common case, according to tested traces, and it causes too much noise in
the console.

Fixed: 1306445
Change-Id: I6eb5fb6dc3855bc264b3b91cc47d7a8a37290376
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3532319
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2022-03-23 14:37:40 +00:00
Kateryna Prokopenko ce1a60a6b4 Type all URL vars in TimelineModel and -ProfileTree to UrlString 
Bug: 1299780
Change-Id: I60aa62049c261ebbf7ad9cae2ae6f7a9f9cccccb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3532033
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-23 09:44:20 +00:00
Philip Rogers a018b13fb7 Add a Pre-Paint devtools timeline event (devtools side) 
The performance panel no longer matches the RenderingNG architecture [1]
and there are gaps and inaccuracies. This patch adds a "PrePaint" step
which will replace the "UpdateLayerTree" step. "PrePaint" matches the
current code and the architecture described in the RenderingNG Blogpost.

[1] https://developer.chrome.com/blog/renderingng-architecture/

Bug: 1191032
Change-Id: I9741f60ab4e0ecb6e190350c89856d2702cd7527
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3519245
Reviewed-by: Victor Porof <victorporof@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-03-16 06:04:17 +00:00
Mingjing Zhang a06c2e7c1a Add visualization for partially presented frames 
This CL makes the following changes in the Frames timeline:

1. Add a new category of frame visualization, i.e. partially presented
frames, represented as yellow boxes.

2. Enhance accessibility by introducing non-color visual cues to
differentiate various types of frames. Specifically the CL overlays
a dense solid-line pattern on dropped frames and a sparse dashed-line
pattern on partially presented frames.

This CL requires https://crrev.com/c/3211516 to fully function.

Bug: 1261130
Change-Id: Iba00e415ffdec7839a0c1e8ed6163df718c89c16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3439658
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
 2022-02-10 20:20:41 +00:00
Tim van der Lippe 269e9ae3eb Replace any in return values for void 
This applies the following regex to the codebase:

=> any

and replaces it with

=> void

All obsolete typescript-eslint disable rules have been removed as well.

R=szuend@chromium.org

Bug: 1172300
Change-Id: I98dc2153f539c68853ed4e9cba8503a4b69763ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3338347
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-14 14:27:48 +00:00
Simon Zünd fe7a0d52a9 [cleanup] Remove unnecessary Closure-style casts 
R=tvanderlippe@chromium.org

Bug: None
Change-Id: Ie15c5caaf048023c6a1d8077f91f1a0e5864b7af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3334539
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-13 10:31:14 +00:00
Simon Zünd 7b7b35e178 Revert "Remove V8 Runtime call stats experiment and corresponding code" 
This reverts commit 5a4048ceb0.

Reason for revert: Functionality will stay around.

Original change's description:
> Remove V8 Runtime call stats experiment and corresponding code
>
> R=​alexrudenko@chromium.org
>
> Fixed: 1272432
> Change-Id: Ic4cfa52e7eff3a89c8bb22882d3cc18117c4242b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295525
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: 1272432
Change-Id: I2fca19948a2f1a98123fbd3e8a53b542ee029fb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302099
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-25 07:20:14 +00:00
Simon Zünd 5a4048ceb0 Remove V8 Runtime call stats experiment and corresponding code 
R=alexrudenko@chromium.org

Fixed: 1272432
Change-Id: Ic4cfa52e7eff3a89c8bb22882d3cc18117c4242b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295525
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-22 13:15:49 +00:00
Mingjing Zhang aec1ec3abc Align frames in the Frames timeline with BeginFrame events 
This CL improves the visualization of the Frames timeline such that
frames are now demarcated with BeginFrame events instead of DrawFrame
and DroppedFrame events. After this change, all visualized frames (both
presented and dropped) are VSync-aligned and their durations are always
multiples of 1/refresh rate.

This new Frames timeline behaviour requires updates of some web tests,
which were temporarily disabled by https://crrev.com/c/3197870 to allow
the current CL to land.

Design doc: https://docs.google.com/document/d/1XjOp05FoShB7bAGoovD4bCBL8L4E8vsEqsPfBKO8ko0/edit?usp=sharing

Bug: 1192637
Change-Id: I98778bdc9e41502ed7705c5083c1dc681c27a7bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3083645
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-09-30 18:34:34 +00:00
Stefan Zager 7c37902a08 Handle invalid nodeId on paint timeline events 
In preparation for this chromium patch:

https://chromium-review.googlesource.com/c/chromium/src/+/3107796

Bug: chromium:1191032
Change-Id: I2b4e66131d387f1264d05592689ba86ee3a42b2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3142825
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
 2021-09-15 17:48:15 +00:00
Leszek Swirski e199c5a8a7 [timeline] Update model for new produce cache trace events 
These are introduced in https://crrev.com/c/3110827 and disentangle
script/module compilation from cache production. This should make it
clearer for devs that a slice on the timeline is producing a code cache,
and not actually compiling.

Bug: chromium:1242848
Change-Id: I178ec731c2e0a919cbd804040c423df71984d421
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3115970
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-08-25 08:12:51 +00:00
Sigurd Schneider 19b55237a3 Type annotate with Page.FrameId consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I76ece085a7e448558f1f2553179c42b1188888d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3083710
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-13 17:28:44 +00:00
Jan Scheffler 744e3fb5cd [Underscore Migration] Migrate models 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: Ia25ac337cf7be99e2b18b95cf15f19eb559f22fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077389
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 11:10:51 +00:00
Jan Scheffler 665486fe26 Reland "[Underscore Migration] Migrate models/timeline_model" 
This is a reland of 1f51cdfa4a

Original change's description:
> [Underscore Migration] Migrate models/timeline_model
>
> This patch is part of the underscore migration that adds the private
> keyword to all properties that start with an underscore and removes the
> underscore.
>
> Bug:chromium:1207342
> Change-Id: I3e5c2a79e0e497cdcb203f400d78d0f237d5ec11
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3078240
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
> Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: chromium:1207342
Change-Id: I03db3f94af65be8bbbc5ad70d9bbfc4ee9e240ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080317
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2021-08-09 14:54:47 +00:00
Changhao Han bf60f7ab4b Revert "[Underscore Migration] Migrate models/timeline_model" 
This reverts commit 1f51cdfa4a.

Reason for revert: https://crbug.com/1237786

Original change's description:
> [Underscore Migration] Migrate models/timeline_model
>
> This patch is part of the underscore migration that adds the private
> keyword to all properties that start with an underscore and removes the
> underscore.
>
> Bug:chromium:1207342
> Change-Id: I3e5c2a79e0e497cdcb203f400d78d0f237d5ec11
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3078240
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
> Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: chromium:1207342
Change-Id: I4b613ede12e52b3c9c1bc55ae218ff9a332a7f24
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080299
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-08-09 07:00:36 +00:00
Jan Scheffler 1f51cdfa4a [Underscore Migration] Migrate models/timeline_model 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: I3e5c2a79e0e497cdcb203f400d78d0f237d5ec11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3078240
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-07 17:55:54 +00:00
Kriti Sapra 56daf78ddb Updated no-multiple-empty-lines to only have 1 as max 
DISABLE_THIRD_PARTY_CHECK=updated linting formatting
Bug: 1106746
Change-Id: I371bca95b7cf1e8b7eaa4f9e7c3860af4eedee3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057042
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-28 14:10:15 +00:00
Sigurd Schneider 3375dea80b Resolve TODOs in core/common/SegmentedRange 
Bug: chromium:1172300
Change-Id: I35b264f62da664e4bc76118f6211856770bff93f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3029983
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-16 10:20:49 +00:00
Sigurd Schneider e18ce8ea87 Ensure DOM.BackendNodeId is type-annotated consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I8ce305dfcefcd81b93c3decf931b747da160c7ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003253
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-07-06 09:40:16 +00:00
Camillo Bruni 4871d3718e [timeline] Show detailed compile events 
Expose lazy compile and non-concurrent optimization on the timeline.
Rather often, long functions on the timeline are actually not executing
JS code but are rather being blocked on lazy compilation or code
optimization.

Bug: chromium:1101713
Change-Id: Iecc7e35e31e37070d6c474dbd8501324dd6f0147
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003439
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
 2021-07-05 13:43:36 +00:00
Sigurd Schneider f3bfbad90c Tentatively fix problem with missing requestId 
We got a bug report that I cannot reproduce locally and that
triggers the error:
Uncaught (in promise) TypeError:
Cannot read property 'requestId' of undefined",
source:
devtools://devtools/bundled/models/timeline_model/timeline_model.js

This CL attempts to fix this by guarding accesses to requestId.

Bug: chromium:1225948
Change-Id: I186456a19a868e26ddac3a73b85858ffa3a53da5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3001845
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-02 09:23:30 +00:00
Jan Scheffler 03323f8a26 [Underscore Migration] Prework 
This patch renames non trivial getters or setters to better convey
what they do.

Bug:chromium:1207342
Change-Id: I244c20976a6546f887d7d31343ee234019182c32
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2969426
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-06-22 07:54:57 +00:00
Jan Scheffler a4469c3a47 [Underscore Migration] Prework on sdk/ 
This patch renames non trivial getters to better convey what they do.

Bug:chromium:1207342
Change-Id: I96672e7d82e163db2b0f1159a1be1358f3e9adb1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2969425
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-06-18 11:27:44 +00:00
Sigurd Schneider 79e812efee Move Target to its own file 
Bug: chromium:1213943
Change-Id: I309436e8608c3f89ac42a117a3f454b5e43eef16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2933138
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-06-04 07:24:06 +00:00
Sigurd Schneider b9f6c7910e Move TargetManager to its own file 
Change-Id: I4708a6303198bc5c4ff6aa8e2b2a2f5e4530725f
Bug: chromium:1213943
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919763
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-31 11:24:26 +00:00
Simon Zünd d74e151c60 Add missing dependencies 
Experimenting with remote build execution revealed that many TypeScript
targets are not specifying all their dependencies in GN.

R=tvanderlippe@chromium.org

Bug: 1211289
Change-Id: Ie4d1dbedd1d8190595281bfe3715169b61cba3d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2912735
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-25 11:13:33 +00:00
Tim van der Lippe 025a168806 Add missing DEPS on protocol 
When we made the protocol importable, the `ts_library` targets no
longer recompile when we update the protocol. To make sure that
all `ts_library` targets recompile when doing so, we need to
add the proper DEPS on them.

This patch makes sure that https://crrev.com/c/2902705 is correctly
recompiling (and failing DevTools) with the protocol update.

Longterm, we should enforce that all imported modules are listed
in the BUILD.gn file, to make sure that they recompile when required.

R=szuend@chromium.org

Bug: 1210830
Change-Id: I9fa108f84edf4f431328aa26e2df25fb1f440732
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905501
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-05-19 11:46:33 +00:00
Tim van der Lippe 038d808e1a Import protocol types in models/ 
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: Icfda82842d5bd1e1da5fff109605925113fc651b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897516
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-05-17 07:59:52 +00:00
Tim van der Lippe eb876c6b1e Generate const enums in protocol.d.ts 
Some files currently rely on the Protocol to be available on the
global scope. However, the Protocol definitions are defined in
a .d.ts file, which isn't available on runtime. Therefore,
attempting to import Protocol with non-type imports would retain
the imports in the `.js` files and break on runtime.

Since the only usages of the Protocol on runtime are the enums,
we can make them const, such that they get inlined as intended.
Then, `import * as` will work again, as the enums are inlined and
the import is removed from the `.js` file.

DISABLE_THIRD_PARTY_CHECK=Protocol update
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: I749e57c9f51596866b61cab686c59f00bc8a8eb4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897277
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-05-14 15:51:00 +00:00
Sigurd Schneider e967dcb9be Don't adjust line numbers more than once on trace import 
Bug: chromium:1205430
Change-Id: Id2d37562988a4b9fc9bf6e442a3eb9c316b70d90
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2871719
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-05-05 11:43:06 +00:00
Tim van der Lippe 300f2b3d7b Add GN visibility for models/ 
Downstream projects can define the devtools_models_visibility in
their `default_args` in their `.gn` file to add any other
dependencies.

R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I7e9ab02d3bcb0f76b170f3a5ffe67afb790d6285
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854687
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-28 13:07:14 +00:00
Tim van der Lippe eea44828fe Add GN visibility to all legacy targets 
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I47b05c25df571de948ab59e9abcc6a62d0146ff2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854677
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-28 09:57:04 +00:00
Tim van der Lippe bbb43fbe74 Consolidate owners in models/ 
Not every single person was present in all folders, but these owners
were present in a majority of all folders.

R=yangguo@chromium.org

Bug: 1187573
Change-Id: I4ed38d3e118715ab3ed14bd261095b0c8d54e6e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2848235
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-04-26 13:51:40 +00:00
Paul Irish 03f91c46e7 [Performance] Include 'Compute Intersections' on flamechart 
Bug:1199137
Change-Id: I65722d1d9abdb72abe9a5bbd3a4480af67ae5a66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2827158
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-15 21:05:45 +00:00
Jan Scheffler 72cbd362b8 [JSDOC2TS]: Migrate sdk 
Bug: chromium:1158760
Change-Id: I71e54327fb343a6e64be2b13ff5e69093d4977a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2821546
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-04-13 11:06:57 +00:00
Tim van der Lippe 08af7653a1 Move timeline_model to models/timeline_model 
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: Ie9451b76ccfda59c48c46dce73c3e3d83b9c79d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815017
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-08 16:20:03 +00:00