zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-29 16:57:00 +08:00
Code Issues Packages Projects Releases Wiki Activity
2,955 Commits 43 Branches 79 Tags
c8f6ffd7c303d108cc983af7deea3b4bd46870f1
Commit Graph
2955 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tim van der Lippe c8f6ffd7c3 Update ESLint to 6.8.0 
Also update the PRESUBMIT linter configuration to make sure
it actually runs the linter when updating ESLint. Otherwise,
it would not properly do the full linter check.

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update ESLint

Bug: 1068145
Change-Id: Ibf2de156366dc64c90ee1aced5537d2038e7a268
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137384
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-06 13:52:18 +00:00
Tim van der Lippe 35cca41271 Allow manage_node_deps to run custom npm commands 
This allows us to execute the following:

npm run install-deps -- outdated

Which is equivalent to `npm outdated`, although it will run on the
actual node_modules output (that we can verify is unchanged).

Most of the npm commands require the private information to exist.
Therefore, if we run a custom command we first have to install with
`npm ci` to get the private information. Then we have to execute
the command, perform the cleanup and only after that finisht the
script. If we would bail out right after executing the custom command,
the private information would remain in the repository.

R=jacktfranklin@chromium.org

Fixed: 1068132
Change-Id: I50d3538a7115783dea19e1899faf17b1622f22ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137381
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-06 13:01:08 +00:00
Wolfgang Beyer 21ebdb46fc Revert "Add infobar about issues panel to console" 
This reverts commit 23b1ed62a1.

Reason for revert: <should be behind experiment flag>

Original change's description:
> Add infobar about issues panel to console
> 
> This CL adds a sticky infobar to the console. It shows up whenever
> issues are detected and notifies users about the existence of the new
> issues panel. The bar disappears automatically when the user navigates
> to a page for which no issues are detected.
> 
> Screenshot: https://imgur.com/Jk95x7n
> 
> Fixed: chromium:1061876
> Change-Id: I9ec5aaab510021a77721a2b39b9e1b52197f4abb
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128132
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

TBR=szuend@chromium.org,wolfi@chromium.org

Change-Id: I936e9743f6f71d7faca9880b9e39c414902ded67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137382
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-04-06 12:10:38 +00:00
Wolfgang Beyer 23b1ed62a1 Add infobar about issues panel to console 
This CL adds a sticky infobar to the console. It shows up whenever
issues are detected and notifies users about the existence of the new
issues panel. The bar disappears automatically when the user navigates
to a page for which no issues are detected.

Screenshot: https://imgur.com/Jk95x7n

Fixed: chromium:1061876
Change-Id: I9ec5aaab510021a77721a2b39b9e1b52197f4abb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128132
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-06 08:16:48 +00:00
Brian Cui 7ff61c6fba Add alt text to Screencast canvas element 
This small CL adds alt text to the screencast canvas element so screen
reader software can read aloud a text description of the graphic.

Previously, NVDA would only say "graphic" when the screencast view
was focused.

Result: https://i.imgur.com/bHOy9vo.mp4

Bug: 1067074
Change-Id: Ie3737352cb5f8c9c569b82a73b26d45bb0337131
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2133221
Reviewed-by: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Commit-Queue: Brian Cui <brcui@microsoft.com>
 2020-04-03 18:32:05 +00:00
Michael Liao 2d6db0b9fd [Applications - Clear Storage]: Fix pie chart focus 
Issue:
- Clear Storage View is constantly re-initializing the pie chart when storage usage is at 0
	- This is because the code was null checking by using !this._quotaUsage

-Pie charts shouldn't be stealing focus on initialization

Changes:
- Changed null check to this._quotaUsage === null
- Removed element.focus call from _setSelectedElement
	- focusPrevious/focusNext already focus element, so it is redundant
	- _focusClickedElement doesn't need to focus the element

Bug: 1066374
Change-Id: I051b60b151698a1569870590b532440e74b0f1b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2135011
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
 2020-04-03 16:44:53 +00:00
Eric Leese bdb35569f7 Reland "Show unbound breakpoints as disabled" 
This is a reland of ca63eb417e

Original change's description:
> Show unbound breakpoints as disabled
>
> We need the UI to distinguish between a successfully bound breakpoint
> and one that has not been bound. This change makes unbound breakpoints
> look like disabled breakpoints, though that could be changed to a
> different icon in the future.
>
> This change also eliminates a race condition in some tests by waiting
> for a breakpoint to be bound after setting it.
>
> Fixed: chromium:1063864, chromium:1064581
> Change-Id: Id181a19efd7f9939a1555368b9367aaa22af0fd2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128131
> Commit-Queue: Eric Leese <leese@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Change-Id: I02c4ce21a617f797862fb8f5ec996ef2e45c20ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2132227
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2020-04-03 16:34:23 +00:00
Mathias Bynens 2af328044c Count WTF-8 byte size without encoding 
In `ExpandableTextPropertyValue`, we’re doing a full WTF-8 encode
just to get the byte size of the result. Instead, we can compute
the total byte size without the overhead of doing any encoding.
For the string `'Iñtërnâtiônàlizætiøn☃💩'.repeat(1_000_000)` this
reduces the runtime cost from 166 ms to 98 ms. For the string
`'ASCII-only'.repeat(1_000_000)` the runtime cost increases only
slightly, from 42 ms to 45 ms.

This patch introduces `StringUtilities.countWtf8Bytes` to do exactly
that. Note that WTF-8 [1] is like UTF-8 with additional support for
lone surrogates. We need to support lone surrogates in this case,
since `ExpandableTextPropertyValue` is potentially dealing with
JavaScript strings.

[1]: https://simonsapin.github.io/wtf-8/

Bug: chromium:1024721
Change-Id: I00d0cd8ecd328daddb43b2476229d5e4e47038e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2134308
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-04-03 11:08:53 +00:00
Alex R 76336cdd04 Set background color for scrollbars in dark mode 
The color of the scrollbar track was transparent in the dark mode.
It works for most of the panels but it does not work well for the
live expressions panel in Console. This change sets the scrollbar
background color to rgb(36, 36, 36) in dark mode. This color is
the background color for most of the UI elements with a scrollbar.

Screenshot: https://drive.google.com/open?id=1D-4hJqpGx2ZYDVcYWNWydFqIiNGXjBUU

Bug: 953677
Change-Id: Ib382b38cd6c16852bd7c0240d99b25abe73b110c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2135606
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2020-04-03 10:16:43 +00:00
Alex R 8475bb3343 Make TreeOutline in Changes not focusable until there is content 
When the empty TreeOutline in Changes panel gets focus via keyboard,
the outline is shown without any content. This change disable focus
until there is some content in the aforementioned TreeOutline.

Bug: 1048986
Change-Id: I9aa9c24a0197a9fd23a862cc803ce785196a6a2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2132236
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
 2020-04-03 08:54:03 +00:00
Jack Lynch a10679ba4c Fix maybeLinkifyScriptLocation fallback strategy 
Currently, there's a regression where some links in the performance
panel fail to update when the scripts that they point to are
pretty-printed. This was introduced when Components.Linkifier was made
accessible here [1] and a complicated ternary statement was rewritten
into an if-else. Dropping the else restores the previous functionality
and solves the regression. While debugging, I came across another issue
where call frame column numbers were not being used, so I fixed that as
well.

[1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891546

Bug: 1061379
Change-Id: I839c2db7bebadf9c8183f517554dfd5af293a349
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119659
Reviewed-by: Brian Cui <brcui@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
 2020-04-02 23:45:23 +00:00
Michael Liao cafccfd0e5 [Elements - Styles Pane]: Adding SR announcement when adding a class successfully using '.cls' button 
Issue:
- SR is silent when adding a class via the '.cls' button. This can confuse users relying on screen readers since there is no feedback from adding a class.

Change:
- Adding an UI.ARIAUtils.alert(...) call that states when a class is added.

SR functionality:
https://imgur.com/NYE9JIt

Bug: 1066163
Change-Id: I2e70c3cd52d2237136d7825a2ba81acb6641f0ef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127974
Reviewed-by: Tony Ross <tross@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
 2020-04-02 19:54:01 +00:00
Mike Jackson 33cc65df59 Revert "Avoid automatically reloading DevTools on Theme change" 
This reverts commit 64e0899efa.

Reason for revert: stabilizing for 83

Original change's description:
> Avoid automatically reloading DevTools on Theme change
>
> Avoid automatically reloading the DevTools when the user changes
> the theme within the DevTools . The user will be notified that a
> Reload is required, and the settings page now has a "Reload DevTools"
> button so the user can apply the changes immediately.
>
> Reloading the DevTools automatically can result in the user losing
> any state with their current debugging sessions (e.g. pause location,
> console logs, style changes, etc).
>
> https://imgur.com/a/47ICsdi
>
> Bug: 1001549
> Change-Id: I338dea7610a9a51c8292743a84c274a60e034b34
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107500
> Commit-Queue: Mike Jackson <mjackson@microsoft.com>
> Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>

TBR=mjackson@microsoft.com,Rob.Paveza@microsoft.com,ambake@microsoft.com


Bug: 1001549
Change-Id: I5718269c0808fb784acfeb5b32959ac85986bce0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2134076
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
 2020-04-02 16:06:51 +00:00
Kayce Basques 9f18b64390 Update What's New UI for Chrome 83 
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=986998#c27

Bug: 986998
Change-Id: Ifd346e85210d977897078ae9d8046703d545baac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2131094
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Kayce Basques <kayce@google.com>
Auto-Submit: Kayce Basques <kayce@google.com>
 2020-04-02 15:17:20 +00:00
Alex R cb77de6ed6 Disable expanding the Timings group in Timeline if it's empty 
The related bug describes a problem of the Timings group
overlapping with the content. Whereas overlapping is intended,
the UI can be improved by hiding the expand/collapse button when
the group contains no additional content to show.

Screenshots:
- https://drive.google.com/open?id=17CTTv4ihhba-HMYGV7ansehv_YFtK2Hv
- https://drive.google.com/open?id=1NuU8p1GuorQjNU84Ph8gdtgCG2-EDCqo

Bug: 1066427
Change-Id: I6f197e4fd52564eddc40b9e0f7bc997d30e1d603
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2132235
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2020-04-02 15:13:14 +00:00
Alex R b32fb08ef1 Reposition tooltip if the mouse moves 
The related bug describes a situation when the tooltip looks misaligned
if you navigate to it from another opened toolip. It happens because
the new tooltip is opened on the first mouse event and is placed
relative to the border of the anchor element (where the mouse is).
Therefore, it looks misaligned because the user moves the mouse
pointer further. This change implements the repositioning of the tooltip
 on subsequent events.  An alternative approach would be to position the
tooltip relative to the anchor element only and avoid using mouse
pointer coordinates.

Bug: 1039631
Change-Id: Idfcb59318ce9c44f8397573d759e17dcdd08314f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2132237
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-04-02 14:56:42 +00:00
Surma 7b79364731 Fix size calculations in ExpandableTextPropertyValue 
Previously, the code calculated the size of the string when using UTF-16
as the encoding. However, UTF-8 is much more common on the web and for
web development, so it makes more sense to use that. This CL changes
the size calculations to use UTF-8 instead.

Bug: 1024721
Change-Id: Iddc5950ffeccb2b561cd5301fb0aba3ec66a873f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2134287
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Surma <surma@chromium.org>
 2020-04-02 14:19:31 +00:00
Philip Pfaffe c980dbf22c Fix a race in the wasmDWARFDebugging experiment 
A race can occur when enabling the wasmDWARFDebuggin experiment. DebuggerModel instances created before that happens are not associated with a plugin manager. We thus need to catch that particular case when new scripts arrive for an existing DebuggerModel after the experiment is enabled.

Change-Id: Iad1fa36c8e8f1a76fae86b1928acd4b38242f009
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2132239
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-04-02 11:42:10 +00:00
Andrey Kosyakov 4d123409dc Improve code hygiene in ExtensionServer 
Bug: 1064519
Change-Id: I9f51bf78a36cf4e96e591d32ed741625f072af06
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2131611
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-01 22:51:50 +00:00
Andrey Kosyakov a08cb9b5eb Disable extensions when inspecting DOM UI 
This disables front-end extensions when DevTools are attached to
privileged pages.

Bug: 1059577, 795595
Change-Id: I0971fd993bee63eea347ffa800c3cc72e09ba334
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128732
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-01 22:27:20 +00:00
Surma 0a34c98ea0 Important changes to Whitespace 
Change-Id: Id2d3fd2efdf7df4c5a337a361d9dd960d912a096
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2132228
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Surma <surma@chromium.org>
 2020-04-01 14:52:09 +00:00
Paul Lewis 7108574e87 [e2e] Fails tests on in-page errors 
Change-Id: Iba880410eab9d154d0d236b70eb7895963e252ed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2130793
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-01 13:09:09 +00:00
Paul Lewis aa978561a3 Revert "Show unbound breakpoints as disabled" 
This reverts commit ca63eb417e.

Reason for revert: These tests are causing timeouts on bots

Original change's description:
> Show unbound breakpoints as disabled
> 
> We need the UI to distinguish between a successfully bound breakpoint
> and one that has not been bound. This change makes unbound breakpoints
> look like disabled breakpoints, though that could be changed to a
> different icon in the future.
> 
> This change also eliminates a race condition in some tests by waiting
> for a breakpoint to be bound after setting it.
> 
> Fixed: chromium:1063864, chromium:1064581
> Change-Id: Id181a19efd7f9939a1555368b9367aaa22af0fd2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128131
> Commit-Queue: Eric Leese <leese@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,szuend@chromium.org,tvanderlippe@chromium.org,leese@chromium.org,mathiasb@google.com

Change-Id: I52ba7d595f526f6beee9469193a262bbbb424839
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2132226
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-04-01 12:26:39 +00:00
Wolfgang Beyer c839d063ef Round design for logpoint icon 
This CL replaces the square-shaped logpoint icon with a circular one.
Now all 3 types of breakpoints are consistently visualized with
different kinds of circular icons.

Screenshots:
before: https://imgur.com/4gXXqog
after: https://imgur.com/OxYOi1w

Bug: chromium:1041830
Change-Id: I804a7f4fe2e850c9e7cb8341eb2c63338bb24acd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2130788
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-04-01 11:38:49 +00:00
Paul Lewis 9edf7517be [Experience] Adds layout shifts to performance timeline 
This is an MVP of showing Cumulative Layout Shifts in the DevTools
Timeline. A future CL will contain rect overlays to show the affected
regions, but for now we have a track that shows the records.

Image showing the change: https://imgur.com/eUKpLKS

See: https://web.dev/cls
Bug: 1054447,1054381
Change-Id: Ic0c2febdf60383fa9f90c438e3697ea74d97d108
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2130366
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-01 11:26:39 +00:00
Paul Lewis 48dc466eea [e2e] Fix selection after delete 
Discovered a race condition when running e2e in SLOWMO. This CL fixes
the race condition by ensuring that the old content is definitely
grabbed before the backspace key is pressed.

Change-Id: I6f39f18b8352ed03a1b6e4c067a2e526589b4ace
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2130789
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-01 11:24:59 +00:00
Eric Leese ca63eb417e Show unbound breakpoints as disabled 
We need the UI to distinguish between a successfully bound breakpoint
and one that has not been bound. This change makes unbound breakpoints
look like disabled breakpoints, though that could be changed to a
different icon in the future.

This change also eliminates a race condition in some tests by waiting
for a breakpoint to be bound after setting it.

Fixed: chromium:1063864, chromium:1064581
Change-Id: Id181a19efd7f9939a1555368b9367aaa22af0fd2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128131
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-01 11:09:09 +00:00
Paul Lewis 2ced406be1 [e2e] Skips flaky network datagrid tests 
Bug: 1066813
Change-Id: Idb79c659003377c3501d3cb06e55055451685245
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2130791
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-04-01 10:57:39 +00:00
Ted Meyer 7e5ebf014b Adds End2End test for the Media tab. 
I had to add support for running the tests with chromium
--enable-features flags. This isn't on by default though, I'll leave
that up to you to turn on. The tests just exit early if the flag isn't
present.

Change-Id: I132ca71796d8f069a6fba0342f10f2f2b18c7b62
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2125249
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-31 16:29:03 +00:00
Tim van der Lippe 68cc95ec12 Remove support for front_end fallback in unittests 
The fallback confuses language servers which breaks code editor integration.
Moreover, it is incompatible with `ts_library`, as `ts_library` has no
concept of path aliases.

R=jacktfranklin@chromium.org

Change-Id: If7e00cce62397f47a04b763a3105c04415dd77b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128137
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-31 13:22:23 +00:00
Kim-Anh Tran 2dbeb5da18 Update CDP and add string to reflect stack scope in scope view 
DISABLE_THIRD_PARTY_CHECK=Change to reflect CDP update

Bug: chromium:1043034
Bug: v8:10347
Change-Id: I777072a1263f93b228263d065c2e0e95707774dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128128
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2020-03-31 12:26:33 +00:00
Simon Zünd d7f02588fc [formatter] Improve formatting for code containing await expressions 
This CL adds basic formatting support for 'await' expressions. While
the result is not perfect, we no longer print the argument to the
AwaitExpression on a single line.

R=yangguo@chromium.org

Bug: chromium:1062617
Change-Id: Ic0e93b3ec6daec8fde53c8395c43ebc42bb19843
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127006
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-03-31 07:43:14 +00:00
Michael Liao 17111b3e43 [Elements - Styles Pane]: Fixing SR behavior for element state pane 
Element State Pane: https://imgur.com/u6O3im1

Issue:
- Forced element state checkboxes use a table element for layout purposes
- SR is announcing the checkbox container as a table which can cause confusion to SR users

Changes:
- Set the role for the table element as "presentation"

Usage of "role=presentation":
The presentation role is used to remove semantic meaning from an element and any of its related child elements. For example, a table used for layout purposes could have the presentation role applied to the table element to remove any semantic meaning from the table element and any of its table related children elements, such as table headers and table data elements. Non-table related elements should retain their semantic meaning, however.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_presentation_role

Bug: 1065913
Change-Id: I24d7b2b8fccc7983a574ddd8d385e8f15e79b90d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127671
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Songtao Xia <soxia@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
 2020-03-30 19:09:52 +00:00
Tim van der Lippe 3fffd0d459 Remove unused global references from ui-legacy.js 
This caught some leftover usages in ui itself, as well as the devices
pane which wasn't ported to ESM yet.

R=aerotwist@chromium.org

Change-Id: I48f01c3b982b68111fedd3cf4a26b91ed21204ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2124490
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-30 12:00:31 +00:00
Tim van der Lippe 990f2d1fe4 Use built-in Map instead of object map 
Use Map instead of an object map, as a Map is intended for this
purpose. We should probably clean up other usages of object maps
as well.

R=yangguo@chromium.org

Change-Id: Ic9342e42f974617de4b8c40d8253a2b3a562e8d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2122139
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-03-30 11:58:41 +00:00
Tim van der Lippe 0ccd8de267 Fix logging of page errors in e2e-test 
This will now properly show up the errors if they are thrown in
an e2e-test:

Page Error in Frontend
Error: Error: Error from sdk-legacy.js
    at http://localhost:8090/front_end/sdk/sdk-legacy.js:249:7
Page Error in Frontend
Error: Error: Error from sdk-legacy.js
    at http://localhost:8090/front_end/sdk/sdk-legacy.js:249:7
Worker (17606): /Users/tvanderlippe/Projects/devtools/devtools-frontend/test/e2e/elements/sidebar-event-listeners-remove.js

R=aerotwist@chromium.org

Change-Id: Ia171bdffc4fb28591b40277c33861ce392516d09
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2124489
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-03-30 11:33:52 +00:00
Jack Franklin e5a40bf349 Add basic unit tests to CookieParser 
Trying to at least get some tests to aid in some future refactorings.

Change-Id: I7b4d995120b281917a1565e791717dfe7d71d1e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2124488
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-30 08:48:56 +00:00
Paul Lewis ca9a03f92f [e2e] Adds various helpers; tidies up env vars 
Change-Id: I0babf1394d62f37628c8812f9b593b40d03a30da
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2124491
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-27 17:39:36 +00:00
Jack Franklin a35ca2b5e9 E2E test for element breadcrumbs 
Bug: 1032561
Change-Id: I20fc343ab5edcae1b10bc837edfed70ab876bdda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123482
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-03-27 15:11:15 +00:00
Tim van der Lippe 42fa3ce18f Remove unused global references from sdk-legacy.js 
R=aerotwist@chromium.org

Bug: 1064958
Change-Id: Ia4b1a337ca753fb76ed6c780614dfe45b4c32c83
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123485
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-03-27 14:57:22 +00:00
Jack Franklin 60f529d224 Expand event listener e2e tests 
This CL adds a test for listing properties of a custom event.

Bug: 1044632
Change-Id: Ibf08173ba878d68b3877399cd0e21794a9581ff2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2122142
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-03-27 14:10:31 +00:00
Simon Zünd a27ec02e9e Move 'issues' module from 'shell' to 'devtools_app' and 'worker_app' 
The issues module depends on the network module. As we do not want to
add the network module to shell, we lift the issues module "upwards"
into the two application configurations that 1) extend from shell and
2) have network available.

R=sigurds@chromium.org, tvanderlippe@chromium.org

Change-Id: Ic975edf871d1e9cd60a65aa0dc800564aa1b7931
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123478
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-03-27 13:21:41 +00:00
Simon Zünd 8a8c01075b [issues] Clicking on affected requests will open the details view 
Instead of just highlighting the affected request in the network panel,
clicking the link now opens the detailed view for a request in the
network panel.

This CL adds a new utility method on the {NetworkPanel} that ties
together existing functionality. Currently, clicking an affected
request opens the "Headers" tab of the request. This is done because
the "Affected Requests" views is re-used for all issues where requests
are attached, not just cookie issues. In the future, we might be able
to pass along some data, so we could choose the opened tab depending
whether its a cookie or a COEP issue.

R=sigurds@chromium.org

Change-Id: I1118b2e2c428c6135f895816d1f7fdaf4d4ce79b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123481
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-03-27 12:51:51 +00:00
Tim van der Lippe 08bbaec4c3 Remove unused global exports from common-legacy.js 
R=aerotwist@chromium.org

Bug: 1064958
Change-Id: I33028a71ca0c47562985774c95f34e8292be2604
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2122143
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-27 12:37:21 +00:00
Changhao Han d1b1b5fac5 add check to ensure style pane update 
Deleting the last property in a styles section incorrectly skips style pane update.
This check ensures style pane update when the property's index is out-of-bound.

Bug: chromium:1060267
Change-Id: Ic4073b03c482285fd75b0dc9f1e1800534fce112
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123472
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-27 12:22:16 +00:00
Tim van der Lippe 846c6a1466 Remove unused global references in workspace-legacy.js 
These are not used in our layout tests or module.json files

R=aerotwist@chromium.org

Bug: 1064958
Change-Id: Ia80d231758e202de92daa2bf53ae9c0e5476f545
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2122141
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-27 12:21:11 +00:00
Paul Lewis 417c5c06b2 [e2e] Adds support for logs and errors 
This CL adds support for piping through stderr from the workers, and
adds an extra helper for logging messages from the worker to the master
process.

Change-Id: I39c31e8150456df12635f951fc6015a0bbe59960
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123479
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-27 12:19:31 +00:00
Paul Lewis 7234471130 [e2e] Adds support for setting a timeout 
This CL allows the setting of a TIMEOUT env variable to control test
timeout values.

Includes a drive-by fix on only outputting actual and expected values
when they are set.

Bug: 1062614
Change-Id: Idf444778a8a7292052a489a758b57bd2cfac81f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123470
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-03-27 12:18:01 +00:00
Tim van der Lippe 73758da483 Add test that verifies Ninja does not do any work when no changes are made 
If no source files are changed, then Ninja should not do any work.

R=jacktfranklin@chromium.org
CC=rob.paveza@microsoft.com

Bug: 1064287
Change-Id: Ie1da13683c1b9455a5f121ebe47bb47dcb539438
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2122350
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-27 12:16:21 +00:00
Peter Marshall 7fa53f2a96 [ui] Fix color picker switcher style for dark-mode 
There was a custom dark mode style applied which got inverted by the
dark mode theme which generates inverted colors for the light mode
CSS.

Just removing the custom hover left the inverted-hover color a bit too
dark to see on the dark background.
Fix this by setting the light mode hover grey to one shade darker,
meaning the inverted dark hover is now lighter.

Dark before: https://imgur.com/BmquXSB
Dark after: https://imgur.com/ZaY0lsI

Light before: https://imgur.com/rYgxSsO
Light after: https://imgur.com/uExaLnt

Fixed: chromium:1064959

Change-Id: I44efe8995cb4132725b08e234ec2bb00fc1d4054
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123480
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-27 12:09:51 +00:00